Issue 10821035: wip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Created:
8 years, 5 months ago by Nico

Modified:
7 years, 7 months ago

Reviewers:

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, ncarter (slow), mihaip-chromium-reviews_chromium.org, akalin, estade+watch_chromium.org, Raghu Simha, yoshiki+watch_chromium.org, jam, feature-media-reviews_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org, gbillock+watch_chromium.org, smckay+watch_chromium.org, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

wip BUG=138550 TEST=

Patch Set 1 #

Patch Set 2 : wip #

Patch Set 3 : all builds #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Patch Set 8 : carbon #

Patch Set 9 : simplercarbon #

Patch Set 10 : carbon3 #

Patch Set 11 : carbon4 #

Patch Set 12 : rebase #

Patch Set 13 : rebase #

Patch Set 14 : rebase #

Patch Set 15 : . #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -48 lines)			Patch
M	chrome/browser/bookmarks/bookmark_html_writer.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_model.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_web_ui.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/favicon/favicon_handler.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/favicon/favicon_service.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/favicon/favicon_tab_helper.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/history/history_backend.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/history/history_types.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	1 chunk	+11 lines, -5 lines	0 comments	Download
M	chrome/browser/history/history_types.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	1 chunk	+8 lines, -1 line	0 comments	Download
M	chrome/browser/history/thumbnail_database_unittest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/session_model_associator.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	1 chunk	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/history_menu_bridge.mm	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_controller.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/search_engines/template_url_table_model.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/toolbar/back_forward_menu_model.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/extensions/extension_icon_source.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/favicon_source.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/ntp/app_launcher_handler.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/favicon_webui_handler.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/renderer/chrome_render_view_observer.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
A	tools/mac/dump-static-initializers.py	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	1 chunk	+55 lines, -0 lines	0 comments	Download