wip

chrome/renderer/chrome_render_view_observer.cc

Index: chrome/renderer/chrome_render_view_observer.cc
diff --git a/chrome/renderer/chrome_render_view_observer.cc b/chrome/renderer/chrome_render_view_observer.cc
index 5093e43c1ee35a2d2e659b99784ac97a63950a07..dfb3d6dfea73aa4dc880be467e610d5011533310 100644
--- a/chrome/renderer/chrome_render_view_observer.cc
+++ b/chrome/renderer/chrome_render_view_observer.cc
@@ -327,6 +327,12 @@ void ChromeRenderViewObserver::OnJavaScriptStressTestControl(int cmd,
 void ChromeRenderViewObserver::OnDownloadFavicon(int id,
                                                  const GURL& image_url,
                                                  int image_size) {
+  // I don't have much of an opinion on whether IconMsg_DownloadFavicon decodes
+  // just a single frame for an .ico file or attempts to decode frames for all
+  // ui::GetSupportedScaleFactors() / gfx::Screen::GetScaleFactorsInUse(). I
+  // expect other people to have opinions though. Check with oshima@, he might
+  // have an opinion about this.  Please ping me if you want to discuss or if
+  // something I wrote is confusing.
   bool data_image_failed = false;
   if (image_url.SchemeIs("data")) {
     SkBitmap data_image = ImageFromDataUrl(image_url);