[MIPS] Patch for QEMU 0.12.5 for NaCl on MIPS.

[MIPS] Patch for QEMU 0.12.5 for NaCl on MIPS.

    The current set in Native Client for MIPS is dependent on QEMU 0.12.5 and this
    change includes a patch for it.

    The patch consists of:

    - support for several syscalls (getcpu, epoll_pwait, ioprio_set, ioprio_get,
      utimensat, signalfd, eventfd, fallocate, timerfd_create, timerfd_gettime,
      timerfd_settime, signalfd4, eventfd, epoll_create1, dup3, pipe2,
      inotify_init1)
    - fix for pipe issue (return value is in different registers)
    - fix for sysconf(_SC_OPEN_MAX) issue (clears sign bit which is set by mistake)
    - fix for ftruncate_64 issue (changes qemu to use same order of parameters
      as on arm)
    - fix for pread64 and pwrite64 issues (switches order of offset parameters)
    - fix for issue with madd.d instruction (segfault issue).

The stock qemu was not working for Native Client, so we switched to the version
we previously used. The changes have been cherrypicked from the other qemu
branch, when we came across known issues. This may not be the smallest possible
set of needed changes for NaCl, yet as we plan to switch to QEMU 1.x in future,
this will be removed then anyway.

    BUG= http://code.google.com/p/nativeclient/issues/detail?id=2914
    TEST= none

[petarj, 2012-07-20 16:01:54]

Here is a patch for QEMU 0.12.5 for NaCl on MIPS. The patch has been previously
part of this CL:

http://codereview.chromium.org/10703143/

[robertm, 2012-07-20 16:12:50]

Just to confirm, this will go here:
native_client/../third_party/qemu/

Could file a bug for the switch to 1.X QEMU
and reference it here.
BTW: does the stock qemu-mips work for you at all?
If not which of these changes are crucial for nacl?

one nit: please leave a space after "BUG=" so that the link becomes clickable.

On 2012/07/20 16:01:54, petarj wrote:
> Here is a patch for QEMU 0.12.5 for NaCl on MIPS. The patch has been
previously
> part of this CL:
> 
> http://codereview.chromium.org/10703143/

[petarj, 2012-07-20 16:38:21]

> Just to confirm, this will go here:
> native_client/../third_party/qemu/

I guess I should add it back to the previous change then?

> Could file a bug for the switch to 1.X QEMU
> and reference it here.

Just created:

http://code.google.com/p/nativeclient/issues/detail?id=2914


> BTW: does the stock qemu-mips work for you at all?
> If not which of these changes are crucial for nacl

The stock qemu was not working for Native Client, so we switched to the version
we previously used. The changes have been cherrypicked from the other qemu
branch, when we came across a known issues, but I can not say if all of these
are crucial in the current version.

[robertm, 2012-07-20 17:55:43]

LGTM

On Fri, Jul 20, 2012 at 12:38 PM, <petarj@mips.com> wrote:

>  Just to confirm, this will go here:
>> native_client/../third_party/**qemu/
>>
>
> I guess I should add it back to the previous change then?



you may not be able to combine these directories in one CL,
And since I will have to commit this for you anyway,
it is fine to keep it here.


>
>
>  Could file a bug for the switch to 1.X QEMU
>> and reference it here.
>>
>
> Just created:
>
>
http://code.google.com/p/**nativeclient/issues/detail?id=**2914<http://code.g...
>


thanks.


>
>
>  BTW: does the stock qemu-mips work for you at all?
>> If not which of these changes are crucial for nacl
>>
>
> The stock qemu was not working for Native Client, so we switched to the
> version
> we previously used. The changes have been cherrypicked from the other qemu
> branch, when we came across a known issues, but I can not say if all of
> these
> are crucial in the current version.
>


Might be nice to add this to the description.

>
>
http://codereview.chromium.**org/10810038/<http://codereview.chromium.org/108...
>


I'll try to get this in next week.

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

[petarj, 2012-07-20 18:18:26]

On 2012/07/20 17:55:43, robertm wrote:
> you may not be able to combine these directories in one CL,
> And since I will have to commit this for you anyway,
> it is fine to keep it here.

Ok, then I misunderstood your previous comment (in which I thought you would
like to see it in native_client/src/third_party).

I did expect to see the patch in third_party/qemu next to arm patch, this is
why I isolated it and changed base-url.

> Might be nice to add this to the description.

Done.

> I'll try to get this in next week.

Thanks.

[Robert Muth (chromium), 2012-07-30 17:29:39]

This patch can now be found here:

 ../third_party/qemu/qemu-0.12.5.patch_mips 


On 2012/07/20 18:18:26, petarj wrote:
> On 2012/07/20 17:55:43, robertm wrote:
> > you may not be able to combine these directories in one CL,
> > And since I will have to commit this for you anyway,
> > it is fine to keep it here.
> 
> Ok, then I misunderstood your previous comment (in which I thought you would
> like to see it in native_client/src/third_party).
> 
> I did expect to see the patch in third_party/qemu next to arm patch, this is
> why I isolated it and changed base-url.
> 
> > Might be nice to add this to the description.
> 
> Done.
> 
> > I'll try to get this in next week.
> 
> Thanks.