Roll breakpad DEPS r977:995

webkit/tools/test_shell/test_shell_win.cc

Index: webkit/tools/test_shell/test_shell_win.cc
diff --git a/webkit/tools/test_shell/test_shell_win.cc b/webkit/tools/test_shell/test_shell_win.cc
index 70e1e0531c97540b39474adafee1309b94f87aa9..cfc1595787da69d6c2e514834f862d46e3c3ef60 100644
--- a/webkit/tools/test_shell/test_shell_win.cc
+++ b/webkit/tools/test_shell/test_shell_win.cc
@@ -183,7 +183,7 @@ void TestShell::InitializeTestShell(bool layout_test_mode,
     if (parsed_command_line.HasSwitch(test_shell::kCrashDumpsFulldump)) {
         new google_breakpad::ExceptionHandler(
             dir, 0, &MinidumpCallback, 0, true,

[Mark Mentovai, 2012/07/24 15:27:33]

The 0s should all be NULLs, here and in the else branch.

The “true” argument in both is totally wrong. It should have been
google_breakpad::ExceptionHandler::HANDLER_ALL since 2007, but I guess since we
were using “true,” the zero-change option is
google_breakpad::ExceptionHandler::HANDLER_EXCEPTION. However, this is just
test_shell_win, and this was only allowed to continue on incorrectly because
nobody uses it or cares about it, so I’d change it to HANDLER_ALL now.

[Robert Sesek, 2012/07/24 16:11:14]

Done.

-            kFullDumpType, 0, 0);
+            kFullDumpType, static_cast<const wchar_t*>(0), 0);
     } else {
         new google_breakpad::ExceptionHandler(
             dir, 0, &MinidumpCallback, 0, true);