Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 10805065: Roll breakpad DEPS r977:995 (Closed)

Created:
8 years, 5 months ago by Robert Sesek
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Roll breakpad DEPS r977:995 BUG=137676 TEST=none TBR=deps Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148133

Patch Set 1 #

Patch Set 2 : WORK! #

Total comments: 2

Patch Set 3 : Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M breakpad/breakpad.gyp View 1 5 chunks +9 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_win.cc View 1 2 1 chunk +13 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Robert Sesek
8 years, 5 months ago (2012-07-24 15:12:56 UTC) #1
Mark Mentovai
http://codereview.chromium.org/10805065/diff/12003/webkit/tools/test_shell/test_shell_win.cc File webkit/tools/test_shell/test_shell_win.cc (right): http://codereview.chromium.org/10805065/diff/12003/webkit/tools/test_shell/test_shell_win.cc#newcode185 webkit/tools/test_shell/test_shell_win.cc:185: dir, 0, &MinidumpCallback, 0, true, The 0s should all ...
8 years, 5 months ago (2012-07-24 15:27:33 UTC) #2
Robert Sesek
http://codereview.chromium.org/10805065/diff/12003/webkit/tools/test_shell/test_shell_win.cc File webkit/tools/test_shell/test_shell_win.cc (right): http://codereview.chromium.org/10805065/diff/12003/webkit/tools/test_shell/test_shell_win.cc#newcode185 webkit/tools/test_shell/test_shell_win.cc:185: dir, 0, &MinidumpCallback, 0, true, On 2012/07/24 15:27:33, Mark ...
8 years, 5 months ago (2012-07-24 16:11:14 UTC) #3
Mark Mentovai
L G T M or for the benefit of the CQ LGTM
8 years, 5 months ago (2012-07-24 16:13:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/10805065/14001
8 years, 5 months ago (2012-07-24 16:14:26 UTC) #5
commit-bot: I haz the power
Change committed as 148133
8 years, 5 months ago (2012-07-24 17:20:02 UTC) #6
Mark Seaborn
This change seems to have broken NaCl's Windows Breakpad tests on the main Chrome waterfall, ...
8 years, 5 months ago (2012-07-24 18:58:28 UTC) #7
Ted Mielczarek
You could try backing out r989, although Mozilla has been running with that patch for ...
8 years, 5 months ago (2012-07-24 22:39:56 UTC) #8
Mark Mentovai
src/client/windows/handler/exception_handler.cc in r989 appears to have formatting problems, an unwanted property change, and no real ...
8 years, 5 months ago (2012-07-24 22:42:26 UTC) #9
Mark Mentovai
8 years, 5 months ago (2012-07-24 22:45:51 UTC) #10
Robert, you can try the roll again with Breakpad r998.

Powered by Google App Engine
This is Rietveld 408576698