Roll breakpad DEPS r977:995

webkit/tools/test_shell/test_shell_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/tools/test_shell/test_shell.h"
 
 #include <windows.h>
 #include <commdlg.h>
 #include <objbase.h>
 #include <process.h>
@@ skipping 164 matching lines @@
     HANDLE rc = AddFontMemResourceEx(font_ptr, font_size, 0, &num_fonts);
     DCHECK(rc != 0);
   }
 
   const CommandLine& parsed_command_line = *CommandLine::ForCurrentProcess();
   if (parsed_command_line.HasSwitch(test_shell::kCrashDumps)) {
     string16 dir(
         parsed_command_line.GetSwitchValueNative(test_shell::kCrashDumps));
     if (parsed_command_line.HasSwitch(test_shell::kCrashDumpsFulldump)) {
         new google_breakpad::ExceptionHandler(
             dir, 0, &MinidumpCallback, 0, true,

[Mark Mentovai, 2012/07/24 15:27:33]

The 0s should all be NULLs, here and in the else branch.

The “true” argument in both is totally wrong. It should have been
google_breakpad::ExceptionHandler::HANDLER_ALL since 2007, but I guess since we
were using “true,” the zero-change option is
google_breakpad::ExceptionHandler::HANDLER_EXCEPTION. However, this is just
test_shell_win, and this was only allowed to continue on incorrectly because
nobody uses it or cares about it, so I’d change it to HANDLER_ALL now.

[Robert Sesek, 2012/07/24 16:11:14]

Done.

-            kFullDumpType, 0, 0);
+            kFullDumpType, static_cast<const wchar_t*>(0), 0);
     } else {
         new google_breakpad::ExceptionHandler(
             dir, 0, &MinidumpCallback, 0, true);
     }
   }
 }
 
 void TestShell::DestroyWindow(gfx::NativeWindow windowHandle) {
   // Do we want to tear down some of the machinery behind the scenes too?
   RemoveWindowFromList(windowHandle);
@@ skipping 536 matching lines @@
 
 bool EnsureFontLoaded(HFONT font) {
   return true;
 }
 
 bool DownloadUrl(const std::string& url, HWND caller_window) {
   return false;
 }
 
 }  // namespace webkit_glue