Roll breakpad DEPS r977:995

Roll breakpad DEPS r977:995

BUG=137676
TEST=none
TBR=deps

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148133

[Mark Mentovai, 2012-07-24 15:27:33]

http://codereview.chromium.org/10805065/diff/12003/webkit/tools/test_shell/te...
File webkit/tools/test_shell/test_shell_win.cc (right):

http://codereview.chromium.org/10805065/diff/12003/webkit/tools/test_shell/te...
webkit/tools/test_shell/test_shell_win.cc:185: dir, 0, &MinidumpCallback, 0,
true,
The 0s should all be NULLs, here and in the else branch.

The “true” argument in both is totally wrong. It should have been
google_breakpad::ExceptionHandler::HANDLER_ALL since 2007, but I guess since we
were using “true,” the zero-change option is
google_breakpad::ExceptionHandler::HANDLER_EXCEPTION. However, this is just
test_shell_win, and this was only allowed to continue on incorrectly because
nobody uses it or cares about it, so I’d change it to HANDLER_ALL now.

[Robert Sesek, 2012-07-24 16:11:14]

http://codereview.chromium.org/10805065/diff/12003/webkit/tools/test_shell/te...
File webkit/tools/test_shell/test_shell_win.cc (right):

http://codereview.chromium.org/10805065/diff/12003/webkit/tools/test_shell/te...
webkit/tools/test_shell/test_shell_win.cc:185: dir, 0, &MinidumpCallback, 0,
true,
On 2012/07/24 15:27:33, Mark Mentovai wrote:
> The 0s should all be NULLs, here and in the else branch.
> 
> The “true” argument in both is totally wrong. It should have been
> google_breakpad::ExceptionHandler::HANDLER_ALL since 2007, but I guess since
we
> were using “true,” the zero-change option is
> google_breakpad::ExceptionHandler::HANDLER_EXCEPTION. However, this is just
> test_shell_win, and this was only allowed to continue on incorrectly because
> nobody uses it or cares about it, so I’d change it to HANDLER_ALL now.

Done.

[Mark Mentovai, 2012-07-24 16:13:53]

L
G
T
M

or for the benefit of the CQ

LGTM

[commit-bot: I haz the power, 2012-07-24 16:14:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/10805065/14001

[commit-bot: I haz the power, 2012-07-24 17:20:02]

Change committed as 148133

[Mark Seaborn, 2012-07-24 18:58:28]

This change seems to have broken NaCl's Windows Breakpad tests on the main
Chrome waterfall, both 32-bit and 64-bit:

http://build.chromium.org/p/chromium/buildstatus?builder=NACL%20Tests&number=...
http://build.chromium.org/p/chromium/buildstatus?builder=NACL%20Tests%20%28x6...

The specific failure is:

Traceback (most recent call last):
  File
"E:\b\build\slave\NACL_Tests\build\src\native_client\tests\inbrowser_crash_test\crash_dump_tester.py",
line 165, in <module>
    sys.exit(Main())
  File
"E:\b\build\slave\NACL_Tests\build\src\native_client\tests\inbrowser_crash_test\crash_dump_tester.py",
line 119, in Main
    cleanup_func()
  File
"E:\b\build\slave\NACL_Tests\build\src\native_client\tests\inbrowser_crash_test\crash_dump_tester.py",
line 63, in Cleanup
    proc.terminate()
  File "E:\b\depot_tools\python_bin\lib\subprocess.py", line 911, in terminate
    TerminateProcess(self._handle, 1)
WindowsError: [Error 5] Access is denied
scons: ***
[scons-out\nacl-x86-32\test_results\inbrowser_trusted_crash_in_startup_test.out]
Error 1

This is probably happening because crash_service{,64}.exe is crashing -- if you
call TerminateProcess() on an already-exited process, you get this error.

[Ted Mielczarek, 2012-07-24 22:39:56]

You could try backing out r989, although Mozilla has been running with that
patch for months without issue.

[Mark Mentovai, 2012-07-24 22:42:26]

src/client/windows/handler/exception_handler.cc in r989 appears to have
formatting problems, an unwanted property change, and no real Breakpad review
history, so maybe we should back it out anyway until the proper process is
followed.

[Mark Mentovai, 2012-07-24 22:45:51]

Robert, you can try the roll again with Breakpad r998.