Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 10764002: [NaCl SDK] Set "recommended" tag to "yes" automatically for stable pepper bundle. (Closed)

Created:
8 years, 5 months ago by binji
Modified:
4 years, 4 months ago
CC:
natalia stachniuk
Visibility:
Public.

Description

[NaCl SDK] Set "recommended" tag to "yes" automatically for stable pepper bundle. BUG=none TEST=none NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145801

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -16 lines) Patch
M native_client_sdk/src/build_tools/json/naclsdk_manifest2.json View 3 chunks +5 lines, -5 lines 0 comments Download
M native_client_sdk/src/build_tools/tests/test_update_manifest.py View 2 chunks +11 lines, -9 lines 0 comments Download
M native_client_sdk/src/build_tools/update_nacl_manifest.py View 2 chunks +5 lines, -2 lines 2 comments Download

Messages

Total messages: 13 (2 generated)
binji
8 years, 5 months ago (2012-07-09 17:52:18 UTC) #1
noelallen1
LGTM http://codereview.chromium.org/10764002/diff/1/native_client_sdk/src/build_tools/update_nacl_manifest.py File native_client_sdk/src/build_tools/update_nacl_manifest.py (right): http://codereview.chromium.org/10764002/diff/1/native_client_sdk/src/build_tools/update_nacl_manifest.py#newcode482 native_client_sdk/src/build_tools/update_nacl_manifest.py:482: bundle.recommended = 'no' Does the no mean we ...
8 years, 5 months ago (2012-07-09 21:58:39 UTC) #2
binji
http://codereview.chromium.org/10764002/diff/1/native_client_sdk/src/build_tools/update_nacl_manifest.py File native_client_sdk/src/build_tools/update_nacl_manifest.py (right): http://codereview.chromium.org/10764002/diff/1/native_client_sdk/src/build_tools/update_nacl_manifest.py#newcode482 native_client_sdk/src/build_tools/update_nacl_manifest.py:482: bundle.recommended = 'no' On 2012/07/09 21:58:39, noelallen1 wrote: > ...
8 years, 5 months ago (2012-07-09 22:06:29 UTC) #3
noelallen1
Agreed. Recommended should go away. We should put together a list of changes to the ...
8 years, 5 months ago (2012-07-09 22:14:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/10764002/1
8 years, 5 months ago (2012-07-09 23:58:06 UTC) #5
commit-bot: I haz the power
Change committed as 145801
8 years, 5 months ago (2012-07-09 23:58:34 UTC) #6
natalia stachniuk
lgtm
4 years, 4 months ago (2016-08-24 03:15:59 UTC) #8
natalia stachniuk
lgtm lgtm
4 years, 4 months ago (2016-08-24 03:16:00 UTC) #9
natalia stachniuk
lgtm lgtm lgtm
4 years, 4 months ago (2016-08-24 03:17:42 UTC) #10
natalia stachniuk
4 years, 4 months ago (2016-08-24 03:19:47 UTC) #11
natalia stachniuk
4 years, 4 months ago (2016-08-24 03:23:12 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698