[NaCl SDK] Set "recommended" tag to "yes" automatically for stable pepper bundle.

native_client_sdk/src/build_tools/tests/test_update_manifest.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import copy
 import datetime
 import os
 import posixpath
 import subprocess
@@ skipping 306 matching lines @@
     self.files.Add(B18_0_1025_163_R1_MLW)
     self._MakeDelegate()
     self._Run(OS_MLW)
     self._ReadUploadedManifest()
     self._AssertUploadedManifestHasBundle(B18_0_1025_163_R1_MLW, BETA)
     self._AssertUploadedManifestHasBundle(B19_0_1084_41_R1_MLW, DEV)
     self.assertEqual(len(self.uploaded_manifest.GetBundles()), 2)
 
   def testUpdateTwoBundles(self):
     self.manifest = MakeManifest(B18_R1_NONE, B19_R1_NONE)
-    self.history.Add(OS_MLW, BETA, V19_0_1084_41)
-    self.history.Add(OS_MLW, STABLE, V18_0_1025_163)
+    self.history.Add(OS_MLW, DEV, V19_0_1084_41)
+    self.history.Add(OS_MLW, BETA, V18_0_1025_163)
     self.files.Add(B18_0_1025_163_R1_MLW)
     self.files.Add(B19_0_1084_41_R1_MLW)
     self._MakeDelegate()
     self._Run(OS_MLW)
     self._ReadUploadedManifest()
-    self._AssertUploadedManifestHasBundle(B18_0_1025_163_R1_MLW, STABLE)
-    self._AssertUploadedManifestHasBundle(B19_0_1084_41_R1_MLW, BETA)
+    self._AssertUploadedManifestHasBundle(B18_0_1025_163_R1_MLW, BETA)
+    self._AssertUploadedManifestHasBundle(B19_0_1084_41_R1_MLW, DEV)
     self.assertEqual(len(self.uploaded_manifest.GetBundles()), 2)
 
   def testUpdateWithMissingPlatformsInArchives(self):
     self.manifest = MakeManifest(B18_R1_NONE)
     self.history.Add(OS_MLW, BETA, V18_0_1025_184)
     self.history.Add(OS_MLW, BETA, V18_0_1025_163)
     self.files.Add(B18_0_1025_184_R1_MLW, add_archive_for_os=OS_M)
     self.files.Add(B18_0_1025_163_R1_MLW)
     self._MakeDelegate()
     self._Run(OS_MLW)
     self._ReadUploadedManifest()
     self._AssertUploadedManifestHasBundle(B18_0_1025_163_R1_MLW, BETA)
     self.assertEqual(len(self.uploaded_manifest.GetBundles()), 1)
 
   def testUpdateWithMissingManifestSnippets(self):
     self.manifest = MakeManifest(B18_R1_NONE)
     self.history.Add(OS_MLW, BETA, V18_0_1025_184)
     self.history.Add(OS_MLW, BETA, V18_0_1025_163)
     self.files.Add(B18_0_1025_184_R1_MLW, add_json_for_os=OS_ML)
     self.files.Add(B18_0_1025_163_R1_MLW)
     self._MakeDelegate()
     self._Run(OS_MLW)
     self._ReadUploadedManifest()
     self._AssertUploadedManifestHasBundle(B18_0_1025_163_R1_MLW, BETA)
     self.assertEqual(len(self.uploaded_manifest.GetBundles()), 1)
 
-  def testRecommendedIsMaintained(self):
-    for recommended in 'yes', 'no':
+  def testRecommendedIsStable(self):
+    for channel in STABLE, BETA, DEV, CANARY:
       self.setUp()
       bundle = copy.deepcopy(B18_R1_NONE)
-      bundle.recommended = recommended
       self.manifest = MakeManifest(bundle)
-      self.history.Add(OS_MLW, BETA, V18_0_1025_163)
+      self.history.Add(OS_MLW, channel, V18_0_1025_163)
       self.files.Add(B18_0_1025_163_R1_MLW)
       self._MakeDelegate()
       self._Run(OS_MLW)
       self._ReadUploadedManifest()
       self.assertEqual(len(self.uploaded_manifest.GetBundles()), 1)
       uploaded_bundle = self.uploaded_manifest.GetBundle('pepper_18')
-      self.assertEqual(uploaded_bundle.recommended, recommended)
+      if channel == STABLE:
+        self.assertEqual(uploaded_bundle.recommended, 'yes')
+      else:
+        self.assertEqual(uploaded_bundle.recommended, 'no')
 
   def testNoUpdateWithNonPepperBundle(self):
     self.manifest = MakeManifest(NON_PEPPER_BUNDLE_NOARCHIVES,
         B18_0_1025_163_R1_MLW)
     self._MakeDelegate()
     self._Run(OS_MLW)
     self.assertEqual(self._HasUploadedManifest(), False)
 
   def testUpdateWithHistoryWithExtraneousPlatforms(self):
     self.manifest = MakeManifest(B18_R1_NONE)
@@ skipping 111 matching lines @@
     self._AssertUploadedManifestHasBundle(my_bundle, CANARY)
 
 def main():
   suite = unittest.defaultTestLoader.loadTestsFromModule(sys.modules[__name__])
   result = unittest.TextTestRunner(verbosity=2).run(suite)
 
   return int(not result.wasSuccessful())
 
 if __name__ == '__main__':
   sys.exit(main())