[NaCl SDK] Set "recommended" tag to "yes" automatically for stable pepper bundle.

native_client_sdk/src/build_tools/update_nacl_manifest.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Script that reads omahaproxy and gsutil to determine version of SDK to put
 in manifest.
 """
 
 import buildbot_common
@@ skipping 449 matching lines @@
 
   def Update(self, manifest):
     """Update a manifest and upload it.
 
     Args:
       manifest: The manifest used as a template for updating. Only pepper
       bundles that contain no archives will be considered for auto-updating."""
     for bundle_name, version, channel, archives in self.versions_to_update:
       self.delegate.Print('Updating %s to %s...' % (bundle_name, version))
       bundle = manifest.GetBundle(bundle_name)
-      bundle_recommended = bundle.recommended
       for archive in archives:
         platform_bundle = self._GetPlatformArchiveBundle(archive)
         # Normally the manifest snippet's bundle name matches our bundle name.
         # pepper_canary, however is called "pepper_###" in the manifest
         # snippet.
         platform_bundle.name = bundle_name
         bundle.MergeWithBundle(platform_bundle)
       bundle.stability = channel
-      bundle.recommended = bundle_recommended
+      # We always recommend the stable version.
+      if channel == 'stable':
+        bundle.recommended = 'yes'
+      else:
+        bundle.recommended = 'no'

[noelallen1, 2012/07/09 21:58:39]

Does the no mean we don't recommend anything but?  I suppose that's reasonable. 
Why recommend post stable...

[binji, 2012/07/09 22:06:29]

That's what I figured... I've pretty much been updating the
naclsdk_manifest2.json file to make stable recommended and everything else not.
It's a pain now, because I have to ssh into the master and "svn up" for any
changes like that.

Personally, I think recommended should go away, but I'd have to change the
manifest format to do it... :-/

       manifest.MergeBundle(bundle)
     self._UploadManifest(manifest)
     self.delegate.Print('Done.')
 
   def _GetPlatformArchiveBundle(self, archive):
     """Downloads the manifest "snippet" for an archive, and reads it as a
        Bundle.
 
     Args:
       archive: A full URL of a platform-specific archive, using the gs schema.
@@ skipping 128 matching lines @@
       subject = '[%s] Failed to update manifest' % (scriptname,)
       text = '%s failed.\n\nSTDERR:\n%s\n' % (scriptname, sys.stderr.getvalue())
       SendMail(options.mailfrom, options.mailto, subject, text)
       sys.exit(1)
     else:
       raise
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))