Issue 3985. Tweaks for warning messages

Issue 3985. Tweaks for warning messages
http://code.google.com/p/dart/issues/detail?id=3985


R=devoncarew@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=9451

[devoncarew, 2012-07-08 10:09:16]

lgtm

http://codereview.chromium.org/10704114/diff/1/compiler/java/com/google/dart/...
File compiler/java/com/google/dart/compiler/resolver/Elements.java (right):

http://codereview.chromium.org/10704114/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/resolver/Elements.java:520: String title
= kind.toString();
We could also add a method on ElementKind that would encapsulate the knowledge
that toString().replace("_", " ").toLowerCase() resulted in a user-facing label.

http://codereview.chromium.org/10704114/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/resolver/Elements.java:554: return
MessageFormat.format("{0} line:{1} col:{2}", targetPath, targetInfo.getLine(),
This location information seems overly precise to me. Consider changing:

"Foo.dart line:3 col:11"

to:

"Foo.dart line 3"

your call -

http://codereview.chromium.org/10704114/diff/1/compiler/javatests/com/google/...
File
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java
(right):

http://codereview.chromium.org/10704114/diff/1/compiler/javatests/com/google/...
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java:475:
"Local variable 'foo' is hiding top-level variable 'foo' at Test.dart line:4
col:5",
These error messages look much better!

[scheglov, 2012-07-08 14:01:08]

http://codereview.chromium.org/10704114/diff/1/compiler/java/com/google/dart/...
File compiler/java/com/google/dart/compiler/resolver/Elements.java (right):

http://codereview.chromium.org/10704114/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/resolver/Elements.java:520: String title
= kind.toString();
On 2012/07/08 10:09:16, devoncarew wrote:
> We could also add a method on ElementKind that would encapsulate the knowledge
> that toString().replace("_", " ").toLowerCase() resulted in a user-facing
label.

Well, no we could not.
Because as you can see, user-visible title depends on element parent, not just
on element kind.

http://codereview.chromium.org/10704114/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/resolver/Elements.java:554: return
MessageFormat.format("{0} line:{1} col:{2}", targetPath, targetInfo.getLine(),
On 2012/07/08 10:09:16, devoncarew wrote:
> This location information seems overly precise to me. Consider changing:
> 
> "Foo.dart line:3 col:11"
> 
> to:
> 
> "Foo.dart line 3"
> 
> your call -

This is same information and same format of location as VM prints.
Sometimes you may appreciate column information.