compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java - Issue 10704114: Issue 3985. Tweaks for warning messages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

Issue 10704114: Issue 3985. Tweaks for warning messages (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« compiler/java/com/google/dart/compiler/resolver/Elements.java ('K') | « compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java ('k') | compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java » ('j') | compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java b/compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

index bf82d5a448281e49475335821e73d714b57b5c5a..fdbe9f9e48ec4f47b5d8450496de0650b99e5947 100644

--- a/compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

+++ b/compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

@@ -149,8 +149,10 @@ public class TopLevelElementBuilder {

private void reportDuplicateDeclaration(DartCompilerListener listener, Element element,

Element otherElement) {

- compilationError(listener, element.getNameLocation(), ResolverErrorCode.DUPLICATE_TOP_LEVEL_DECLARATION,

- otherElement, Elements.getRelativeElementLocation(element, otherElement));

+ compilationError(listener, element.getNameLocation(),

+ ResolverErrorCode.DUPLICATE_TOP_LEVEL_DECLARATION,

+ Elements.getUserElementTitle(otherElement),

+ Elements.getRelativeElementLocation(element, otherElement));

}

/**