Reland DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING

chrome/browser/download/download_util.cc

Index: chrome/browser/download/download_util.cc
diff --git a/chrome/browser/download/download_util.cc b/chrome/browser/download/download_util.cc
index 17ba6b5038faeed11330273a420546e776652182..a62f19d2f5190b3345e1e3f09a2dc9fffaf9dc40 100644
--- a/chrome/browser/download/download_util.cc
+++ b/chrome/browser/download/download_util.cc
@@ -514,8 +514,6 @@ DictionaryValue* CreateDownloadItemValue(DownloadItem* download, int id) {
       file_value->SetString("state", "DANGEROUS");
     else
       file_value->SetString("state", "COMPLETE");
-  } else if (download->GetState() == DownloadItem::REMOVING) {
-    file_value->SetString("state", "REMOVING");

[Randy Smith (Not in Mondays), 2012/07/11 17:55:37]

Same question as elsewhere: Have you checked the consumers of this function to
make sure they don't need this notification?

[benjhayden, 2012/07/13 20:03:17]

codesearch says that the only caller of CreateDownloadItemValue() is
chrome/browser/ui/webui/downloads_dom_handler.cc. downloads.js does not use the
REMOVING state. The |downloadsList| message is sent when downloads disappear
from ModelChanged().

   } else {
     NOTREACHED() << "state undefined";
   }