chrome/browser/download/download_path_reservation_tracker_unittest.cc - Issue 10704026: Reland DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_path_reservation_tracker_unittest.cc

Issue 10704026: Reland DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merge Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_path_reservation_tracker.cc ('K') | « chrome/browser/download/download_path_reservation_tracker.cc ('k') | chrome/browser/download/download_test_observer.h » ('j') | chrome/browser/download/download_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_path_reservation_tracker_unittest.cc

diff --git a/chrome/browser/download/download_path_reservation_tracker_unittest.cc b/chrome/browser/download/download_path_reservation_tracker_unittest.cc

index aceaf3b2621f425047e397d65bc582605591f1ec..d004267bc9be4ef81996c6798be56f15295b625f 100644

--- a/chrome/browser/download/download_path_reservation_tracker_unittest.cc

+++ b/chrome/browser/download/download_path_reservation_tracker_unittest.cc

@@ -33,8 +33,7 @@ class FakeDownloadItem : public MockDownloadItem {

explicit FakeDownloadItem()

: state_(IN_PROGRESS) {

}

- ~FakeDownloadItem() {

- SetState(REMOVING);

asanka 2012/07/11 18:12:19 You are going to need a FOR_EACH_OBSERVER(.. OnDow

benjhayden 2012/07/13 20:03:17 Done.

+ virtual ~FakeDownloadItem() {

EXPECT_EQ(0u, observers_.size());

}

virtual void AddObserver(Observer* observer) OVERRIDE {