chrome/browser/extensions/api/downloads/downloads_api.h - Issue 10704026: Reland DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.h

Issue 10704026: Reland DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merge Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_util.cc ('K') | « chrome/browser/download/download_util.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('j') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/downloads/downloads_api.h

diff --git a/chrome/browser/extensions/api/downloads/downloads_api.h b/chrome/browser/extensions/api/downloads/downloads_api.h

index c8a148eb4b8c497e2588142aaa59a5b785aea4e6..c574028d436abb3075345d649a8a37ddb55e11d0 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api.h

+++ b/chrome/browser/extensions/api/downloads/downloads_api.h

@@ -357,7 +357,8 @@ class ExtensionDownloadsEventRouter : public content::DownloadManager::Observer,

virtual void ModelChanged(content::DownloadManager* manager) OVERRIDE;

virtual void ManagerGoingDown(content::DownloadManager* manager) OVERRIDE;

virtual void OnDownloadUpdated(content::DownloadItem* download) OVERRIDE;

- virtual void OnDownloadOpened(content::DownloadItem* download) OVERRIDE;

+ virtual void OnDownloadRemoved(content::DownloadItem* download) OVERRIDE;

+ virtual void OnDownloadDestroyed(content::DownloadItem* download) OVERRIDE;

// Used for testing.

struct DownloadsNotificationSource {