Reland DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING

chrome/browser/download/download_path_reservation_tracker_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop.h"
 #include "base/observer_list.h"
 #include "base/scoped_temp_dir.h"
@@ skipping 15 matching lines @@
 using testing::ReturnRefOfCopy;
 
 namespace {
 
 // MockDownloadItem with real observers and state.
 class FakeDownloadItem : public MockDownloadItem {
  public:
   explicit FakeDownloadItem()
       : state_(IN_PROGRESS) {
   }
-  ~FakeDownloadItem() {
-    SetState(REMOVING);

[asanka, 2012/07/11 18:12:19]

You are going to need a FOR_EACH_OBSERVER(.. OnDownloadDestroyed(this)) here.
Otherwise the tests will fail.

[benjhayden, 2012/07/13 20:03:17]

Done.

+  virtual ~FakeDownloadItem() {
     EXPECT_EQ(0u, observers_.size());
   }
   virtual void AddObserver(Observer* observer) OVERRIDE {
     observers_.AddObserver(observer);
   }
   virtual void RemoveObserver(Observer* observer) OVERRIDE {
     observers_.RemoveObserver(observer);
   }
   virtual void UpdateObservers() OVERRIDE {
     FOR_EACH_OBSERVER(Observer, observers_, OnDownloadUpdated(this));
@@ skipping 369 matching lines @@
   item->UpdateObservers();
   message_loop_.RunAllPending();
   EXPECT_FALSE(IsPathInUse(path));
   EXPECT_TRUE(IsPathInUse(new_target_path));
 
   // Destroying the item should release the reservation.
   item.reset();
   message_loop_.RunAllPending();
   EXPECT_FALSE(IsPathInUse(new_target_path));
 }