Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 10703090: Turn pageAction.show -> browserAction.sensibleThing. (Closed)

Created:
8 years, 5 months ago by not at google - send to devlin
Modified:
8 years, 5 months ago
Reviewers:
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, benwells, koz (OOO until 15th September)
Visibility:
Public.

Description

For pages actions that have been converted into browser actions, convert the pageAction.show/hide API calls into enabling/disabling the browser action. This patch enables it for cocoa and GTK. Views will be slightly more effort, requiring writing new code to give the browser actions disabled appearance and behaviour rather than doing it via the toolkit. Modified from http://codereview.chromium.org/10700007/

Patch Set 1 #

Patch Set 2 : mac #

Patch Set 3 : . #

Patch Set 4 : morestuff #

Patch Set 5 : views (incomplete) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -37 lines) Patch
M chrome/browser/extensions/api/extension_action/extension_actions_api.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.cc View 1 2 3 4 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_action_button.mm View 1 2 3 2 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/browser_action_view.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/browser_action_view.cc View 1 2 3 4 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension.cc View 1 2 3 4 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_action.h View 1 2 3 4 chunks +12 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_action.cc View 1 2 3 4 3 chunks +10 lines, -19 lines 0 comments Download
A chrome/common/extensions/icon_transform.h View 1 2 3 1 chunk +43 lines, -0 lines 0 comments Download
A chrome/common/extensions/icon_transform.cc View 1 2 3 4 1 chunk +40 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698