Turn pageAction.show -> browserAction.sensibleThing.

chrome/browser/ui/cocoa/extensions/browser_action_button.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/browser_action_button.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/logging.h"
@@ skipping 155 matching lines @@
   }
 
   return self;
 }
 
 - (BOOL)acceptsFirstResponder {
   return YES;
 }
 
 - (void)mouseDown:(NSEvent*)theEvent {
-  [[self cell] setHighlighted:YES];
+  if ([self isEnabled])
+    [[self cell] setHighlighted:YES];
   dragCouldStart_ = YES;
 }
 
 - (void)mouseDragged:(NSEvent*)theEvent {
   if (!dragCouldStart_)
     return;
 
   if (!isBeingDragged_) {
     // The start of a drag. Position the button above all others.
     [[self superview] addSubview:self positioned:NSWindowAbove relativeTo:nil];
@@ skipping 62 matching lines @@
 }
 
 - (void)setTabSpecificIcon:(NSImage*)image {
   tabSpecificIcon_.reset([image retain]);
 }
 
 - (void)updateState {
   if (tabId_ < 0)
     return;
 
-  std::string tooltip = extension_->browser_action()->GetTitle(tabId_);
+  ExtensionAction* browser_action = extension_->browser_action();
+  CHECK(browser_action);
+
+  [self setEnabled:browser_action->GetIsVisible(tabId_)];
+
+  std::string tooltip = browser_action->GetTitle(tabId_);
   if (tooltip.empty()) {
     [self setToolTip:nil];
   } else {
     [self setToolTip:base::SysUTF8ToNSString(tooltip)];
   }
 
-  SkBitmap image = extension_->browser_action()->GetIcon(tabId_);
+  SkBitmap image = browser_action->GetIcon(tabId_);
   if (!image.isNull()) {
     [self setTabSpecificIcon:gfx::SkBitmapToNSImage(image)];
     [self setImage:tabSpecificIcon_];
   } else if (defaultIcon_) {
     [self setImage:defaultIcon_];
   }
 
   [[self cell] setTabId:tabId_];
 
   [self setNeedsDisplay:YES];
@@ skipping 49 matching lines @@
 }
 
 - (void)drawInteriorWithFrame:(NSRect)cellFrame inView:(NSView*)controlView {
   gfx::ScopedNSGraphicsContextSaveGState scopedGState;
   [super drawInteriorWithFrame:cellFrame inView:controlView];
   cellFrame.origin.y += kBrowserActionBadgeOriginYOffset;
   [self drawBadgeWithinFrame:cellFrame];
 }
 
 @end