Turn pageAction.show -> browserAction.sensibleThing.

chrome/common/extensions/extension.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension.h"
 
 #include <ostream>
 
 #include "base/base64.h"
 #include "base/basictypes.h"
@@ skipping 794 matching lines @@
 
   return true;
 }
 
 scoped_ptr<ExtensionAction> Extension::LoadExtensionActionHelper(
     const DictionaryValue* extension_action,
     ExtensionAction::Type action_type,
     string16* error) {
   scoped_ptr<ExtensionAction> result(new ExtensionAction(id(), action_type));
 
-  // Page actions are hidden by default, and browser actions ignore
-  // visibility.
-  result->SetIsVisible(ExtensionAction::kDefaultTabId, false);
+  // Page actions are hidden/disabled by default, and browser actions are
+  // visible/enabled by default.
+  if (action_type == ExtensionAction::TYPE_PAGE)
+    result->SetIsVisible(ExtensionAction::kDefaultTabId, false);
+  else
+    result->SetIsVisible(ExtensionAction::kDefaultTabId, true);
 
   if (manifest_version_ == 1) {
     ListValue* icons = NULL;
     if (extension_action->HasKey(keys::kPageActionIcons) &&
         extension_action->GetList(keys::kPageActionIcons, &icons)) {
       for (ListValue::const_iterator iter = icons->begin();
            iter != icons->end(); ++iter) {
         std::string path;
         if (!(*iter)->GetAsString(&path) || path.empty()) {
           *error = ASCIIToUTF16(errors::kInvalidPageActionIconPath);
@@ skipping 3047 matching lines @@
 
 UpdatedExtensionPermissionsInfo::UpdatedExtensionPermissionsInfo(
     const Extension* extension,
     const PermissionSet* permissions,
     Reason reason)
     : reason(reason),
       extension(extension),
       permissions(permissions) {}
 
 }   // namespace extensions