Various token issues fixed in the compiler

Various token issues fixed in the compiler

Committed: https://code.google.com/p/dart/source/detail?r=9199

[Lasse Reichstein Nielsen, 2012-06-27 09:22:16]

LGTM

http://codereview.chromium.org/10697003/diff/7001/lib/compiler/implementation...
File lib/compiler/implementation/compiler.dart (right):

http://codereview.chromium.org/10697003/diff/7001/lib/compiler/implementation...
lib/compiler/implementation/compiler.dart:879: static withOffsets(Token begin,
Token end,
withOffsets -> withCharacterOffsets ?

http://codereview.chromium.org/10697003/diff/7001/lib/compiler/implementation...
lib/compiler/implementation/compiler.dart:882: final endOffset = end.charOffset
+ end.slowCharLength;
slowCharLength -> slowCharCount

http://codereview.chromium.org/10697003/diff/7001/lib/compiler/implementation...
lib/compiler/implementation/compiler.dart:884: // [begin] and [end] might be the
same empty token. This happens for
"the same empty token" -> "the same for the empty token"

http://codereview.chromium.org/10697003/diff/7001/lib/compiler/implementation...
lib/compiler/implementation/compiler.dart:885: // instance when parsing '$$'.
parsing -> scanning.

http://codereview.chromium.org/10697003/diff/7001/lib/compiler/implementation...
File lib/compiler/implementation/elements/elements.dart (right):

http://codereview.chromium.org/10697003/diff/7001/lib/compiler/implementation...
lib/compiler/implementation/elements/elements.dart:371: return
path.substring(path.lastIndexOf('/')+1);
Spaces around '+'.
What is the script name used for? Since file names don't need to be unique, the
script name won't be either.

http://codereview.chromium.org/10697003/diff/7001/lib/compiler/implementation...
File lib/compiler/implementation/tree/nodes.dart (right):

http://codereview.chromium.org/10697003/diff/7001/lib/compiler/implementation...
lib/compiler/implementation/tree/nodes.dart:59: var token = null;
var -> Token.
Style-guide be damned!

http://codereview.chromium.org/10697003/diff/7001/lib/compiler/implementation...
lib/compiler/implementation/tree/nodes.dart:64: // token might be null even when
first is not, e.g. for empty Modifiers.
Make "token" and "first" stand out here, e.g., by wrapping in [...], even if it
isn't a doc-comment.

[ahe, 2012-06-27 10:48:27]

LGTM. I like Lasse's suggestions.

http://codereview.chromium.org/10697003/diff/7001/lib/compiler/implementation...
File lib/compiler/implementation/elements/elements.dart (right):

http://codereview.chromium.org/10697003/diff/7001/lib/compiler/implementation...
lib/compiler/implementation/elements/elements.dart:365: String
getLibraryOrScriptName() {
What is this method for?

[Johnni Winther, 2012-06-27 11:42:18]

PTAL

[Johnni Winther, 2012-06-27 13:53:55]

TBR

Fixes a bug in co19

[floitsch, 2012-06-27 14:06:48]

LGTM to unbreak the build.

http://codereview.chromium.org/10697003/diff/1005/lib/compiler/implementation...
File lib/compiler/implementation/tree/nodes.dart (right):

http://codereview.chromium.org/10697003/diff/1005/lib/compiler/implementation...
lib/compiler/implementation/tree/nodes.dart:359: if (isPrefix) return
super.getEndToken();
as discussed this won't work in all situations.

[Johnni Winther, 2012-06-27 15:24:28]

SendSet.getEndToken() fixed, unit test added
PTAL

[Lasse Reichstein Nielsen, 2012-06-28 07:45:14]

LGTM

https://chromiumcodereview.appspot.com/10697003/diff/7/tests/compiler/dart2js...
File tests/compiler/dart2js/begin_end_token_test.dart (right):

https://chromiumcodereview.appspot.com/10697003/diff/7/tests/compiler/dart2js...
tests/compiler/dart2js/begin_end_token_test.dart:139: text = "a.b++";
How about testing a[b]++ / ++a[b] too?

https://chromiumcodereview.appspot.com/10697003/diff/7/tests/compiler/dart2js...
File tests/compiler/dart2js/scanner_offset_length_test.dart (right):

https://chromiumcodereview.appspot.com/10697003/diff/7/tests/compiler/dart2js...
tests/compiler/dart2js/scanner_offset_length_test.dart:16: var end =
token.charOffset+token.slowCharCount;
spaces around '+'.

[Johnni Winther, 2012-06-28 12:25:32]

PTAL

[Lasse Reichstein Nielsen, 2012-06-28 13:03:52]

LGTM

https://chromiumcodereview.appspot.com/10697003/diff/15001/tests/compiler/dar...
File tests/compiler/dart2js/begin_end_token_test.dart (right):

https://chromiumcodereview.appspot.com/10697003/diff/15001/tests/compiler/dar...
tests/compiler/dart2js/begin_end_token_test.dart:155:
//testNode(sendSet.arguments.head, "b", text);
Generally, if a test fails, add a test that succeeds (e.g., testing for the
erroneous result we get now) so that it will show up when the test is fixed.
Then write a lot of comments to say that it isn't really correct.