Various token issues fixed in the compiler

lib/compiler/implementation/elements/elements.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('elements');
 
 #import('../tree/tree.dart');
 #import('../scanner/scannerlib.dart');
 #import('../leg.dart');  // TODO(karlklose): we only need type.
 #import('../util/util.dart');
@@ skipping 187 matching lines @@
   Element getOutermostEnclosingMemberOrTopLevel() {
     for (Element e = this; e !== null; e = e.enclosingElement) {
       if (e.isMember() || e.isTopLevel()) {
         return e;
       }
     }
     return null;
   }
 
   toString() {
+    // TODO(johnniwinther): Test for nullness of name, or make non-nullness an
+    // invariant for all element types.
     if (!isTopLevel()) {
       String holderName = enclosingElement.name.slowToString();
       return '$kind($holderName#${name.slowToString()})';
     } else {
       return '$kind(${name.slowToString()})';
     }
   }
 
   bool _isNative = false;
   void setNative() { _isNative = true; }
@@ skipping 134 matching lines @@
     elements.forEach((SourceString _, Element e) {
       if (this === e.getLibrary()
           && e.kind !== ElementKind.PREFIX
           && e.kind !== ElementKind.FOREIGN) {
         if (!e.name.isPrivate()) f(e);
       }
     });
   }
 
   bool hasLibraryName() => libraryTag !== null;
+
+  String getLibraryOrScriptName() {

[ahe, 2012/06/27 10:48:27]

What is this method for?

+    if (libraryTag !== null) {
+      return libraryTag.argument.dartString.slowToString();
+    } else {
+      // Use the file name as script name.
+      var path = script.uri.path;
+      return path.substring(path.lastIndexOf('/')+1);

[Lasse Reichstein Nielsen, 2012/06/27 09:22:16]

Spaces around '+'.
What is the script name used for? Since file names don't need to be unique, the
script name won't be either.

+    }
+  }
 }
 
 class PrefixElement extends Element {
   Map<SourceString, Element> imported;
   Token firstPosition;
 
   PrefixElement(SourceString prefix, Element enclosing, this.firstPosition)
     : imported = new Map<SourceString, Element>(),
       super(prefix, ElementKind.PREFIX, enclosing);
 
@@ skipping 692 matching lines @@
   final Node node;
   Type bound;
   Type type;
   TypeVariableElement(name, Element enclosing, this.node, this.type,
                       [this.bound])
     : super(name, ElementKind.TYPE_VARIABLE, enclosing);
   Type computeType(compiler) => type;
   Node parseNode(compiler) => node;
   toString() => "${enclosingElement.toString()}.${name.slowToString()}";
 }