chrome/browser/chromeos/extensions/media_player_event_router.cc - Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/media_player_event_router.cc

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing memory leak in a test. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/input_method_event_router.cc ('k') | chrome/browser/extensions/api/alarms/alarm_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/media_player_event_router.cc

diff --git a/chrome/browser/chromeos/extensions/media_player_event_router.cc b/chrome/browser/chromeos/extensions/media_player_event_router.cc

index baa4096f136366cd6cfffecb86ec8c05f33d83a4..9d3fbc6bc5caa0d6638843f493e3c2d6e7f4bfaf 100644

--- a/chrome/browser/chromeos/extensions/media_player_event_router.cc

+++ b/chrome/browser/chromeos/extensions/media_player_event_router.cc

@@ -23,7 +23,8 @@ void ExtensionMediaPlayerEventRouter::Init(Profile* profile) {

void ExtensionMediaPlayerEventRouter::NotifyPlaylistChanged() {

if (profile_ && profile_->GetExtensionEventRouter()) {

+ scoped_ptr<ListValue> args(new ListValue());

profile_->GetExtensionEventRouter()->DispatchEventToRenderers(

- "mediaPlayerPrivate.onPlaylistChanged", "[]", NULL, GURL());

+ "mediaPlayerPrivate.onPlaylistChanged", args.Pass(), NULL, GURL());

}