chrome/browser/chromeos/extensions/input_method_event_router.cc - Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/input_method_event_router.cc

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing memory leak in a test. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_handler_util.cc ('k') | chrome/browser/chromeos/extensions/media_player_event_router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/input_method_event_router.cc

diff --git a/chrome/browser/chromeos/extensions/input_method_event_router.cc b/chrome/browser/chromeos/extensions/input_method_event_router.cc

index 281e879a6b059d5b596e947533750d8485140175..c332f7801f68eb488de09b3d334ae2e7d6e0f96b 100644

--- a/chrome/browser/chromeos/extensions/input_method_event_router.cc

+++ b/chrome/browser/chromeos/extensions/input_method_event_router.cc

@@ -40,17 +40,15 @@ void ExtensionInputMethodEventRouter::InputMethodChanged(

if (!router->HasEventListener(extensions::event_names::kOnInputMethodChanged))

return;

- ListValue args;

+ scoped_ptr<ListValue> args(new ListValue());

StringValue *input_method_name = new StringValue(

GetInputMethodForXkb(manager->GetCurrentInputMethod().id()));

- args.Append(input_method_name);

- std::string args_json;

- base::JSONWriter::Write(&args, &args_json);

+ args->Append(input_method_name);

// The router will only send the event to extensions that are listening.

router->DispatchEventToRenderers(

- extensions::event_names::kOnInputMethodChanged,

- args_json, profile, GURL());

+ extensions::event_names::kOnInputMethodChanged, args.Pass(), profile,

+ GURL());

}

std::string ExtensionInputMethodEventRouter::GetInputMethodForXkb(