chrome/browser/extensions/api/alarms/alarm_manager.cc - Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/alarms/alarm_manager.cc

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing memory leak in a test. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/media_player_event_router.cc ('k') | chrome/browser/extensions/api/api_resource_event_notifier.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/alarms/alarm_manager.cc

diff --git a/chrome/browser/extensions/api/alarms/alarm_manager.cc b/chrome/browser/extensions/api/alarms/alarm_manager.cc

index cf7257689298b6de441aa91ec6d4eb4b86d75b30..2b451cd38fde3c36a5a268d434ac84c39f2d4892 100644

--- a/chrome/browser/extensions/api/alarms/alarm_manager.cc

+++ b/chrome/browser/extensions/api/alarms/alarm_manager.cc

@@ -38,12 +38,10 @@ class DefaultAlarmDelegate : public AlarmManager::Delegate {

virtual void OnAlarm(const std::string& extension_id,

const Alarm& alarm) {

- ListValue args;

- std::string json_args;

- args.Append(alarm.js_alarm->ToValue().release());

- base::JSONWriter::Write(&args, &json_args);

+ scoped_ptr<ListValue> args(new ListValue());

+ args->Append(alarm.js_alarm->ToValue().release());

ExtensionSystem::Get(profile_)->event_router()->DispatchEventToExtension(

- extension_id, kOnAlarmEvent, json_args, NULL, GURL());

+ extension_id, kOnAlarmEvent, args.Pass(), NULL, GURL());

}

private: