chrome/browser/chromeos/extensions/file_handler_util.cc - Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_handler_util.cc

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing memory leak in a test. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_browser_event_router.cc ('k') | chrome/browser/chromeos/extensions/input_method_event_router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_handler_util.cc

diff --git a/chrome/browser/chromeos/extensions/file_handler_util.cc b/chrome/browser/chromeos/extensions/file_handler_util.cc

index 126e58595701453491fcb3a000e93a71035d3a8d..396b5e9b836cd8b98e6e975bd3d9688826f87c00 100644

--- a/chrome/browser/chromeos/extensions/file_handler_util.cc

+++ b/chrome/browser/chromeos/extensions/file_handler_util.cc

@@ -817,7 +817,7 @@ void ExtensionTaskExecutor::SetupPermissionsAndDispatchEvent(

DictionaryValue* details = new DictionaryValue();

event_args->Append(details);

// Get file definitions. These will be replaced with Entry instances by

- // chromeHidden.Event.dispatchJSON() method from even_binding.js.

+ // chromeHidden.Event.dispatchEvent() method from event_binding.js.

ListValue* files_urls = new ListValue();

details->Set("entries", files_urls);

for (FileDefinitionList::const_iterator iter = file_list.begin();

@@ -841,11 +841,9 @@ void ExtensionTaskExecutor::SetupPermissionsAndDispatchEvent(

details->SetInteger("tab_id", ExtensionTabUtil::GetTabId(contents));

}

- std::string json_args;

- base::JSONWriter::Write(event_args.get(), &json_args);

event_router->DispatchEventToExtension(

extension_id_, std::string("fileBrowserHandler.onExecute"),

- json_args, profile(), GURL());

+ event_args.Pass(), profile(), GURL());

ExecuteDoneOnUIThread(true);

}

@@ -897,4 +895,3 @@ void ExtensionTaskExecutor::SetupHandlerHostFileAccessPermissions(

}

} // namespace file_handler_util