Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: chrome/browser/extensions/api/cookies/cookies_api.cc

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase and review changes. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/cookies/cookies_api.cc
diff --git a/chrome/browser/extensions/api/cookies/cookies_api.cc b/chrome/browser/extensions/api/cookies/cookies_api.cc
index cb17f3096c346c74a6b0b309e59d40a4fd076692..f6f38bf0fdb1890ba69ed8dad7a5ee25a3d64933 100644
--- a/chrome/browser/extensions/api/cookies/cookies_api.cc
+++ b/chrome/browser/extensions/api/cookies/cookies_api.cc
@@ -64,7 +64,7 @@ void ExtensionCookiesEventRouter::Observe(
void ExtensionCookiesEventRouter::CookieChanged(
Profile* profile,
ChromeCookieDetails* details) {
- ListValue args;
+ ListValue* args = new ListValue();
DictionaryValue* dict = new DictionaryValue();
dict->SetBoolean(keys::kRemovedKey, details->removed);
dict->Set(
@@ -100,22 +100,20 @@ void ExtensionCookiesEventRouter::CookieChanged(
}
dict->SetString(keys::kCauseKey, cause);
- args.Append(dict);
+ args->Append(dict);
- std::string json_args;
- base::JSONWriter::Write(&args, &json_args);
GURL cookie_domain =
cookies_helpers::GetURLFromCanonicalCookie(*details->cookie);
- DispatchEvent(profile, keys::kOnChanged, json_args, cookie_domain);
+ DispatchEvent(profile, keys::kOnChanged, args, cookie_domain);
}
void ExtensionCookiesEventRouter::DispatchEvent(Profile* profile,
const char* event_name,
- const std::string& json_args,
+ ListValue* event_args,
GURL& cookie_domain) {
if (profile && profile->GetExtensionEventRouter()) {
profile->GetExtensionEventRouter()->DispatchEventToRenderers(
- event_name, json_args, profile, cookie_domain, EventFilteringInfo());
+ event_name, event_args, profile, cookie_domain, EventFilteringInfo());
}
}

Powered by Google App Engine
This is Rietveld 408576698