Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5776)

Unified Diff: chrome/browser/bookmarks/bookmark_manager_extension_api.cc

Issue 10694085: Refactor extension event distribution to use Values instead of JSON strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase and review changes. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_manager_extension_api.cc
diff --git a/chrome/browser/bookmarks/bookmark_manager_extension_api.cc b/chrome/browser/bookmarks/bookmark_manager_extension_api.cc
index 4679096644c041f6a3b14c3ad7af4a9429e51431..d8887795496c4a4130c47065b9b7850576ffd0c8 100644
--- a/chrome/browser/bookmarks/bookmark_manager_extension_api.cc
+++ b/chrome/browser/bookmarks/bookmark_manager_extension_api.cc
@@ -166,14 +166,12 @@ BookmarkManagerExtensionEventRouter::~BookmarkManagerExtensionEventRouter() {
}
void BookmarkManagerExtensionEventRouter::DispatchEvent(const char* event_name,
- const ListValue* args) {
+ ListValue* args) {
if (!profile_->GetExtensionEventRouter())
return;
- std::string json_args;
- base::JSONWriter::Write(args, &json_args);
profile_->GetExtensionEventRouter()->DispatchEventToRenderers(
- event_name, json_args, NULL, GURL(), extensions::EventFilteringInfo());
+ event_name, args, NULL, GURL(), extensions::EventFilteringInfo());
}
void BookmarkManagerExtensionEventRouter::DispatchDragEvent(
@@ -181,9 +179,9 @@ void BookmarkManagerExtensionEventRouter::DispatchDragEvent(
if (data.size() == 0)
return;
- ListValue args;
- BookmarkNodeDataToJSON(profile_, data, &args);
- DispatchEvent(event_name, &args);
+ ListValue* args = new ListValue();
miket_OOO 2012/07/10 22:33:19 I talked to Antony and confirmed that this apparen
+ BookmarkNodeDataToJSON(profile_, data, args);
+ DispatchEvent(event_name, args);
}
void BookmarkManagerExtensionEventRouter::OnDragEnter(

Powered by Google App Engine
This is Rietveld 408576698