Refactor extension event distribution to use Values instead of JSON strings.

chrome/browser/bookmarks/bookmark_manager_extension_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/bookmarks/bookmark_manager_extension_api.h"
 
 #include <vector>
 
 #include "base/json/json_writer.h"
 #include "base/string_number_conversions.h"
@@ skipping 148 matching lines @@
     tab_(tab) {
   tab_->bookmark_tab_helper()->SetBookmarkDragDelegate(this);
 }
 
 BookmarkManagerExtensionEventRouter::~BookmarkManagerExtensionEventRouter() {
   if (tab_->bookmark_tab_helper()->GetBookmarkDragDelegate() == this)
     tab_->bookmark_tab_helper()->SetBookmarkDragDelegate(NULL);
 }
 
 void BookmarkManagerExtensionEventRouter::DispatchEvent(const char* event_name,
-                                                        const ListValue* args) {
+                                                        ListValue* args) {
   if (!profile_->GetExtensionEventRouter())
     return;
 
-  std::string json_args;
-  base::JSONWriter::Write(args, &json_args);
   profile_->GetExtensionEventRouter()->DispatchEventToRenderers(
-      event_name, json_args, NULL, GURL(), extensions::EventFilteringInfo());
+      event_name, args, NULL, GURL(), extensions::EventFilteringInfo());
 }
 
 void BookmarkManagerExtensionEventRouter::DispatchDragEvent(
     const BookmarkNodeData& data, const char* event_name) {
   if (data.size() == 0)
     return;
 
-  ListValue args;
-  BookmarkNodeDataToJSON(profile_, data, &args);
-  DispatchEvent(event_name, &args);
+  ListValue* args = new ListValue();

[miket_OOO, 2012/07/10 22:33:19]

I talked to Antony and confirmed that this apparent new leak is fixed (though
the way it leaked, and the way it's fixed, it more complex than it appears
here).

+  BookmarkNodeDataToJSON(profile_, data, args);
+  DispatchEvent(event_name, args);
 }
 
 void BookmarkManagerExtensionEventRouter::OnDragEnter(
     const BookmarkNodeData& data) {
   DispatchDragEvent(data, keys::kOnBookmarkDragEnter);
 }
 
 void BookmarkManagerExtensionEventRouter::OnDragOver(
     const BookmarkNodeData& data) {
   // Intentionally empty since these events happens too often and floods the
@@ skipping 312 matching lines @@
   bool can_open_new_windows = true;
 
 #if defined(OS_WIN)
   if (base::win::IsMetroProcess())
     can_open_new_windows = false;
 #endif  // OS_WIN
 
   result_.reset(Value::CreateBooleanValue(can_open_new_windows));
   return true;
 }