Allow OpenSSLPrivateKeyStore and Android global app context leaking.

net/base/openssl_private_key_store_android.cc

Index: net/base/openssl_private_key_store_android.cc
===================================================================
--- net/base/openssl_private_key_store_android.cc	(revision 154951)
+++ net/base/openssl_private_key_store_android.cc	(working copy)
@@ -47,7 +47,10 @@
   }
 
   static OpenSSLKeyStoreAndroid* GetInstance() {
-    return Singleton<OpenSSLKeyStoreAndroid>::get();
+    // We allow the OpenSSL key store to be leaked, because it is used
+    // from a non-joinable worker that is not stopped on shutdown.

[Ryan Sleevi, 2012/09/05 17:29:00]

comment nit: "we"

[Johnny(Jianning) Ding, 2012/09/06 10:34:44]

Done.

+    return Singleton<OpenSSLKeyStoreAndroid,

[Ryan Sleevi, 2012/09/05 17:29:00]

style nit: In general, templates such as this tend to be indented like method
declaration/definitions, rather than method calls. So if the successive template
arguments cannot be aligned with the first argument, follow the four-space rule.

Singleton<
    OpenSSLKeyStoreAndroid,
    LeakySingletonTraits<OpenSSLKeyStoreAndroid> >::get()

[Johnny(Jianning) Ding, 2012/09/06 10:34:44]

Done.

+        LeakySingletonTraits<OpenSSLKeyStoreAndroid> >::get();

[Ryan Sleevi, 2012/09/05 17:29:00]

nit: It may be helpful to have this as a typedef (around line 17), just to
highlight the Singleton-ness.

[Johnny(Jianning) Ding, 2012/09/06 10:34:44]

Done.

   }
 
  private: