Allow OpenSSLPrivateKeyStore and Android global app context leaking.

base/android/jni_android.cc

Index: base/android/jni_android.cc
===================================================================
--- base/android/jni_android.cc	(revision 154951)
+++ base/android/jni_android.cc	(working copy)
@@ -20,7 +20,10 @@
 
 JavaVM* g_jvm = NULL;
 
-base::LazyInstance<base::android::ScopedJavaGlobalRef<jobject> >
+// We allow the global app context to be leaked, because it is used from a
+// non-joinable worker that is not stopped on shutdown and there is no harm
+// to leak it.

[Ryan Sleevi, 2012/09/05 17:29:00]

style nit: Don't use "We" in comments.

Broader comment is this is often pointed out by base/ reviewers (particular
mark). Part of this is about ensuring the language is descriptive, rather than
imperative, as per the Google C++ Guide. The end result of removing "we" often
leads to language that is clearer as to what is guaranteed/expected, whereas
"we" may leave room for a contrasting "they" (eg: "we expect this to be foo" may
lead to a "but THEY expect this to be bar")

I see there are a few other "we"'s in this file, so an extra bonus would be
fixing those few places.

// Leak the global app context, as it is used from a
// non-joinable worker thread that may still be running at
// shutdown. There is no harm in doing this, since [the OS?]
// will clean this up.

[Ryan Sleevi, 2012/09/05 17:29:00]

nit: Within an unnamed namespace, try to preserve the same declaration ordering
as classes.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Declar...

- Typedefs and Enums [Also, types such as classes/structs]
- Constants (static const data members)
- Methods, including static methods

[Johnny(Jianning) Ding, 2012/09/06 10:34:44]

Done.

[Johnny(Jianning) Ding, 2012/09/06 10:34:44]

Done.

+base::LazyInstance<base::android::ScopedJavaGlobalRef<jobject> >::Leaky
     g_application_context = LAZY_INSTANCE_INITIALIZER;
 
 struct MethodIdentifier {