Allow OpenSSLPrivateKeyStore and Android global app context leaking.

net/base/openssl_private_key_store_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/openssl_private_key_store.h"
 
 #include <openssl/evp.h>
 
 #include "base/logging.h"
 #include "base/memory/singleton.h"
@@ skipping 29 matching lines @@
     return ret;
   }
 
   virtual EVP_PKEY* FetchPrivateKey(EVP_PKEY* pkey) {
     // TODO(joth): Implement when client authentication is required.
     NOTIMPLEMENTED();
     return NULL;
   }
 
   static OpenSSLKeyStoreAndroid* GetInstance() {
-    return Singleton<OpenSSLKeyStoreAndroid>::get();
+    // We allow the OpenSSL key store to be leaked, because it is used
+    // from a non-joinable worker that is not stopped on shutdown.

[Ryan Sleevi, 2012/09/05 17:29:00]

comment nit: "we"

[Johnny(Jianning) Ding, 2012/09/06 10:34:44]

Done.

+    return Singleton<OpenSSLKeyStoreAndroid,

[Ryan Sleevi, 2012/09/05 17:29:00]

style nit: In general, templates such as this tend to be indented like method
declaration/definitions, rather than method calls. So if the successive template
arguments cannot be aligned with the first argument, follow the four-space rule.

Singleton<
    OpenSSLKeyStoreAndroid,
    LeakySingletonTraits<OpenSSLKeyStoreAndroid> >::get()

[Johnny(Jianning) Ding, 2012/09/06 10:34:44]

Done.

+        LeakySingletonTraits<OpenSSLKeyStoreAndroid> >::get();

[Ryan Sleevi, 2012/09/05 17:29:00]

nit: It may be helpful to have this as a typedef (around line 17), just to
highlight the Singleton-ness.

[Johnny(Jianning) Ding, 2012/09/06 10:34:44]

Done.

   }
 
  private:
   OpenSSLKeyStoreAndroid() {}
   friend struct DefaultSingletonTraits<OpenSSLKeyStoreAndroid>;

[Ryan Sleevi, 2012/09/05 17:29:00]

nit: not needed anymore with leaky.

[Johnny(Jianning) Ding, 2012/09/06 10:34:44]

it's still needed since the ctor is in private section.
On 2012/09/05 17:29:00, Ryan Sleevi wrote:

 
   DISALLOW_COPY_AND_ASSIGN(OpenSSLKeyStoreAndroid);
 };
 
 }  // namespace
 
 OpenSSLPrivateKeyStore* OpenSSLPrivateKeyStore::GetInstance() {
   return OpenSSLKeyStoreAndroid::GetInstance();
 }
 
 }  // namespace net