NetLogEventParameter to Callback refactoring 7.

NetLogEventParameter to Callback refactoring 7.
Get rid of all uses of NetLogEventParameters in net/proxy.

R=eroman@chromium.org
BUG=126243
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142222

[mmenke, 2012-06-13 15:35:10]

Suspect I'll still need to do 4-6 more of these before the final CL.  Keeping
each one relatively small because I think it minimizes the chance of mistakes.

[eroman, 2012-06-13 18:55:33]

lgtm

http://codereview.chromium.org/10534132/diff/13003/net/proxy/proxy_resolver_j...
File net/proxy/proxy_resolver_js_bindings.cc (right):

http://codereview.chromium.org/10534132/diff/13003/net/proxy/proxy_resolver_j...
net/proxy/proxy_resolver_js_bindings.cc:66: base::Bind(&NetLogAlertCallback,
&message));
Perhaps this can just use a generic NetLogString16Callback.

Only difference from the existing const std::string* flavor is that this is a
string16.

http://codereview.chromium.org/10534132/diff/13003/net/proxy/proxy_script_dec...
File net/proxy/proxy_script_decider.cc (right):

http://codereview.chromium.org/10534132/diff/13003/net/proxy/proxy_script_dec...
net/proxy/proxy_script_decider.cc:213:
CreateSourceStringAndDetermineURL(pac_source, &effective_pac_url,
Can this string construction be internalized into the NetLogCallback?

http://codereview.chromium.org/10534132/diff/13003/net/proxy/proxy_service.cc
File net/proxy/proxy_service.cc (right):

http://codereview.chromium.org/10534132/diff/13003/net/proxy/proxy_service.cc...
net/proxy/proxy_service.cc:1306: std::string pac_string = result->ToPacString();
Can this be internalized into the NetLog callback?

[mmenke, 2012-06-13 20:27:58]

Random note:  This now depends on http://codereview.chromium.org/10546151/.

http://codereview.chromium.org/10534132/diff/13003/net/proxy/proxy_resolver_j...
File net/proxy/proxy_resolver_js_bindings.cc (right):

http://codereview.chromium.org/10534132/diff/13003/net/proxy/proxy_resolver_j...
net/proxy/proxy_resolver_js_bindings.cc:66: base::Bind(&NetLogAlertCallback,
&message));
On 2012/06/13 18:55:33, eroman wrote:
> Perhaps this can just use a generic NetLogString16Callback.
> 
> Only difference from the existing const std::string* flavor is that this is a
> string16.

Done.

http://codereview.chromium.org/10534132/diff/13003/net/proxy/proxy_script_dec...
File net/proxy/proxy_script_decider.cc (right):

http://codereview.chromium.org/10534132/diff/13003/net/proxy/proxy_script_dec...
net/proxy/proxy_script_decider.cc:213:
CreateSourceStringAndDetermineURL(pac_source, &effective_pac_url,
On 2012/06/13 18:55:33, eroman wrote:
> Can this string construction be internalized into the NetLogCallback?


Done.  This does add a little ugliness (Have to duplicate the logic, since it's
a private struct, also has to be a method, which seems a little weird).  Not too
bad, overall, though.

http://codereview.chromium.org/10534132/diff/13003/net/proxy/proxy_service.cc
File net/proxy/proxy_service.cc (right):

http://codereview.chromium.org/10534132/diff/13003/net/proxy/proxy_service.cc...
net/proxy/proxy_service.cc:1306: std::string pac_string = result->ToPacString();
On 2012/06/13 18:55:33, eroman wrote:
> Can this be internalized into the NetLog callback?

Done.  Didn't do it before because of the "IsLoggingAllEvents()" check.

I suspect that once we get rid of the alway-on-observers, we'll want to get rid
of basic logging entirely, and have the NetLog just not get the lock unless it
has active observers.

[commit-bot: I haz the power, 2012-06-14 18:21:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmenke@chromium.org/10534132/1010

[commit-bot: I haz the power, 2012-06-14 21:00:29]

Change committed as 142222