Issue 10546151: A pair of NetLog changes for ongoing refactoring:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10546151: A pair of NetLog changes for ongoing refactoring: (Closed)

Created:
8 years, 6 months ago by mmenke

Modified:
8 years, 6 months ago

Reviewers:
eroman

CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, darin-cc_chromium.org, mmenke

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

A pair of NetLog changes for ongoing refactoring: SourceEventParametersCallback returns NULL on invalid sources, like the old corresponding function. Add a NetLog::StringCallback overload that takes in a string16. R=eroman@chromium.org BUG=126243 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141993

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
	M	net/base/net_log.h	View		2 chunks	+5 lines, -0 lines	1 comment	Download
	M	net/base/net_log.cc	View		3 chunks	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mmenke

http://codereview.chromium.org/10546151/diff/1/net/base/net_log.h File net/base/net_log.h (right): http://codereview.chromium.org/10546151/diff/1/net/base/net_log.h#newcode16 net/base/net_log.h:16: #include "base/string16.h" I don't believe typedefs can be forward ...

8 years, 6 months ago (2012-06-13 19:42:13 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/10546151/1

8 years, 6 months ago (2012-06-13 20:23:39 UTC) #3

Change committed as 141993

Expand Messages | Collapse Messages