Issue 1052003: Keep more track of whether code is from the built...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1052003: Keep more track of whether code is from the built... (Closed)

Created:
10 years, 9 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Keep more track of whether code is from the built in .js files in V8. This change gets bleeding edge a tiny bit closer to the partial snapshots branch. Committed: http://code.google.com/p/v8/source/detail?r=4150

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -11 lines)			Patch
M	src/api.cc	View	1 chunk	+8 lines, -2 lines	0 comments	Download
M	src/bootstrapper.cc	View	1 chunk	+9 lines, -2 lines	0 comments	Download
M	src/compiler.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/compiler.cc	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/debug.cc	View	1 chunk	+8 lines, -2 lines	0 comments	Download
M	src/globals.h	View	1 chunk	+5 lines, -0 lines	1 comment	Download
M	src/handles.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-compiler.cc	View	1 chunk	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

10 years, 9 months ago (2010-03-16 21:58:01 UTC) #2

LGTM

http://codereview.chromium.org/1052003/diff/1/9
File src/globals.h (right):

http://codereview.chromium.org/1052003/diff/1/9#newcode325
src/globals.h:325: // Flag indicating whether code is built in to the VM (one of
the natives
in to -> into?

Expand Messages | Collapse Messages