Removed file_path_watcher_mac.cc, which isn't used anymore.

Removed file_path_watcher_mac.cc, which isn't used anymore.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140272

[Joao da Silva, 2012-06-03 10:47:43]

http://codereview.chromium.org/8393013 renamed file_path_watcher_mac.cc to
*_kqueue.cc, but then http://codereview.chromium.org/8341026/ was merged and
introduced the file again. This CL removes it and adds the changes from the
latter CL to *_kqueue.cc.

I've also noticed that kqueues on the mac do notify of file changes when
observing a directory (used a ConfigDirProvider to check that).

[Joao da Silva, 2012-06-03 14:02:50]

On 2012/06/03 10:47:43, Joao da Silva wrote:
> http://codereview.chromium.org/8393013 renamed file_path_watcher_mac.cc to
> *_kqueue.cc, but then http://codereview.chromium.org/8341026/ was merged and
> introduced the file again. This CL removes it and adds the changes from the
> latter CL to *_kqueue.cc.
> 
> I've also noticed that kqueues on the mac do notify of file changes when
> observing a directory (used a ConfigDirProvider to check that).

Actually, after further testing this doesn't seem to be the case after all :-)

[Mattias Nissler (ping if slow), 2012-06-04 07:40:50]

http://codereview.chromium.org/10500012/diff/3002/base/files/file_path_watche...
File base/files/file_path_watcher_kqueue.cc (right):

http://codereview.chromium.org/10500012/diff/3002/base/files/file_path_watche...
base/files/file_path_watcher_kqueue.cc:208: DPLOG(ERROR) << "close";
Why are you muting all the error logging? Many of these I'd consider pretty
useful.

[Joao da Silva, 2012-06-04 08:06:44]

http://codereview.chromium.org/10500012/diff/3002/base/files/file_path_watche...
File base/files/file_path_watcher_kqueue.cc (right):

http://codereview.chromium.org/10500012/diff/3002/base/files/file_path_watche...
base/files/file_path_watcher_kqueue.cc:208: DPLOG(ERROR) << "close";
On 2012/06/04 07:40:50, Mattias Nissler wrote:
> Why are you muting all the error logging? Many of these I'd consider pretty
> useful.

From http://codereview.chromium.org/8341026/, which is the CL the reintroduced
the _mac.cc file after it was removed.

[Mattias Nissler (ping if slow), 2012-06-04 08:51:30]

On 2012/06/04 08:06:44, Joao da Silva wrote:
>
http://codereview.chromium.org/10500012/diff/3002/base/files/file_path_watche...
> File base/files/file_path_watcher_kqueue.cc (right):
> 
>
http://codereview.chromium.org/10500012/diff/3002/base/files/file_path_watche...
> base/files/file_path_watcher_kqueue.cc:208: DPLOG(ERROR) << "close";
> On 2012/06/04 07:40:50, Mattias Nissler wrote:
> > Why are you muting all the error logging? Many of these I'd consider pretty
> > useful.
> 
> From <crxref style="background-image:
url(chrome-extension://mamkkcngfoeihgpkjdkmmfajlamhifpl/res/type/codereview.png);
">http://codereview.chromium.org/8341026/</crxref>, which is the CL the
reintroduced
> the _mac.cc file after it was removed.

Ah, fair enough. LGTM then.

[commit-bot: I haz the power, 2012-06-04 08:53:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10500012/3002

[commit-bot: I haz the power, 2012-06-04 10:25:34]

Change committed as 140272