Issue 8393013: rename file_path_watcher_mac to file_path_watcher_kqueue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8393013: rename file_path_watcher_mac to file_path_watcher_kqueue (Closed)

Created:
9 years, 2 months ago by Robert Nagy

Modified:
9 years, 2 months ago

Reviewers:
Mark Mentovai, dmac, commit-bot: I haz the power, Mattias Nissler (ping if slow)

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Description

rename file_path_watcher_mac to file_path_watcher_kqueue so that other platforms (*bsd) with kqueue can use it BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107240

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -495 lines)			Patch
M	base/base.gypi	View	4 chunks	+4 lines, -1 line	0 comments	Download
A +	base/files/file_path_watcher_kqueue.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
D	base/files/file_path_watcher_mac.cc	View	1 chunk	+0 lines, -494 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM and CQ. You only need my review to check this in. I love kqueue, ...

9 years, 2 months ago (2011-10-25 20:47:13 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robert.nagy@gmail.com/8393013/1

9 years, 2 months ago (2011-10-25 20:48:10 UTC) #3

Mattias Nissler (ping if slow)

9 years, 1 month ago (2011-10-26 08:40:04 UTC) #5

On Tue, Oct 25, 2011 at 10:47 PM, <mark@chromium.org> wrote:

> LGTM and CQ. You only need my review to check this in.
>
> I love kqueue, by the way.
>

I don't like kqueue when it comes to watching the file system, as it's heavy
on file descriptor consumption :P

That's just to put Mark's unconditional statement of affection into
perspective, kqueue is the best we have on OS X at the moment :)


>
>
http://codereview.chromium.**org/8393013/<http://codereview.chromium.org/8393...
>

Expand Messages | Collapse Messages