Chromium Code Reviews| Index: base/files/file_path_watcher_kqueue.cc |
| diff --git a/base/files/file_path_watcher_kqueue.cc b/base/files/file_path_watcher_kqueue.cc |
| index 29c104a12f82f4dc25ef5c7c67c1a38b8f0a4377..6221a62f379e2385dadabca22de0893451c92068 100644 |
| --- a/base/files/file_path_watcher_kqueue.cc |
| +++ b/base/files/file_path_watcher_kqueue.cc |
| @@ -205,7 +205,7 @@ void FilePathWatcherImpl::CloseFileDescriptor(int *fd) { |
| } |
| if (HANDLE_EINTR(close(*fd)) != 0) { |
| - PLOG(ERROR) << "close"; |
| + DPLOG(ERROR) << "close"; |
|
Mattias Nissler (ping if slow)
2012/06/04 07:40:50
Why are you muting all the error logging? Many of
Joao da Silva
2012/06/04 08:06:44
From http://codereview.chromium.org/8341026/, whic
|
| } |
| *fd = -1; |
| } |
| @@ -213,7 +213,7 @@ void FilePathWatcherImpl::CloseFileDescriptor(int *fd) { |
| bool FilePathWatcherImpl::AreKeventValuesValid(struct kevent* kevents, |
| int count) { |
| if (count < 0) { |
| - PLOG(ERROR) << "kevent"; |
| + DPLOG(ERROR) << "kevent"; |
| return false; |
| } |
| bool valid = true; |
| @@ -237,7 +237,7 @@ bool FilePathWatcherImpl::AreKeventValuesValid(struct kevent* kevents, |
| path_name = base::StringPrintf( |
| "fd %d", *reinterpret_cast<int*>(&kevents[i].ident)); |
| } |
| - LOG(ERROR) << "Error: " << kevents[i].data << " for " << path_name; |
| + DLOG(ERROR) << "Error: " << kevents[i].data << " for " << path_name; |
| valid = false; |
| } |
| } |
| @@ -348,8 +348,8 @@ bool FilePathWatcherImpl::UpdateWatches(bool* target_file_affected) { |
| void FilePathWatcherImpl::OnFileCanReadWithoutBlocking(int fd) { |
| DCHECK(MessageLoopForIO::current()); |
| - CHECK_EQ(fd, kqueue_); |
| - CHECK(events_.size()); |
| + DCHECK_EQ(fd, kqueue_); |
| + DCHECK(events_.size()); |
| // Request the file system update notifications that have occurred and return |
| // them in |updates|. |count| will contain the number of updates that have |
| @@ -442,12 +442,12 @@ bool FilePathWatcherImpl::Watch(const FilePath& path, |
| kqueue_ = kqueue(); |
| if (kqueue_ == -1) { |
| - PLOG(ERROR) << "kqueue"; |
| + DPLOG(ERROR) << "kqueue"; |
| return false; |
| } |
| int last_entry = EventsForPath(target_, &events_); |
| - CHECK_NE(last_entry, 0); |
| + DCHECK_NE(last_entry, 0); |
| EventVector responses(last_entry); |