This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update…

chrome/browser/ui/gtk/password_generation_bubble_gtk.h

Index: chrome/browser/ui/gtk/password_generation_bubble_gtk.h
diff --git a/chrome/browser/ui/gtk/password_generation_bubble_gtk.h b/chrome/browser/ui/gtk/password_generation_bubble_gtk.h
index 1de4e2d205b844b7e4f161eff703ac4a8be5b3da..6432d58f01aa768765566aacce13ffdcd2df2600 100644
--- a/chrome/browser/ui/gtk/password_generation_bubble_gtk.h
+++ b/chrome/browser/ui/gtk/password_generation_bubble_gtk.h
@@ -8,10 +8,15 @@
 
 #include <gtk/gtk.h>
 
-#include "chrome/browser/autofill/password_generator.h"
+#include "base/basictypes.h"
+#include "base/memory/scoped_ptr.h"
 #include "ui/base/gtk/gtk_signal.h"
 #include "ui/gfx/rect.h"
 
+namespace autofill {
+class PasswordGenerator;
+}
+
 namespace content {
 class RenderViewHost;
 }
@@ -28,7 +33,8 @@ class PasswordGenerationBubbleGtk {
   PasswordGenerationBubbleGtk(const gfx::Rect& anchor_rect,
                               GtkWidget* anchor_widget,
                               Profile* profile,
-                              content::RenderViewHost* render_view_host);
+                              content::RenderViewHost* render_view_host,
+                              autofill::PasswordGenerator* password_generator);
   virtual ~PasswordGenerationBubbleGtk();
 
  private:
@@ -44,8 +50,8 @@ class PasswordGenerationBubbleGtk {
   // RenderViewHost associated with the button that spawned this bubble.
   content::RenderViewHost* render_view_host_;
 
-  // Class that deals with generating passwords.
-  autofill::PasswordGenerator password_generator_;
+  // Object that deals with generating passwords.
+  scoped_ptr<autofill::PasswordGenerator> password_generator_;

[Ilya Sherman, 2012/06/04 22:49:15]

If the AutofillManager owns this object, this should be a weak reference rather
than a scoped_ptr.

[Garrett Casto, 2012/06/04 22:58:57]

Is a weak_ptr necessary, or does just a bare pointer suffice? I wouldn't think
that the TabContentsWrapper could disappear while input is being processed. The
overhead for the weak reference isn't that high, I'm just mostly curious.

[Ilya Sherman, 2012/06/04 23:08:22]

A bare pointer suffices.  I didn't actually mean to conjure up thoughts of
weak_ptr when I said "weak reference" -- a bare pointer is what I was thinking
of.

[zysxqn, 2012/06/04 23:17:19]

Done.

 
   DISALLOW_COPY_AND_ASSIGN(PasswordGenerationBubbleGtk);
 };