This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update…

chrome/browser/ui/gtk/password_generation_bubble_gtk.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_GTK_PASSWORD_GENERATION_BUBBLE_GTK_H_
 #define CHROME_BROWSER_UI_GTK_PASSWORD_GENERATION_BUBBLE_GTK_H_
 #pragma once
 
 #include <gtk/gtk.h>
 
-#include "chrome/browser/autofill/password_generator.h"
+#include "base/basictypes.h"
+#include "base/memory/scoped_ptr.h"
 #include "ui/base/gtk/gtk_signal.h"
 #include "ui/gfx/rect.h"
 
+namespace autofill {
+class PasswordGenerator;
+}
+
 namespace content {
 class RenderViewHost;
 }
 
 class BubbleGtk;
 class Profile;
 
 // PasswordGenerationBubbleGtk is a bubble use to show possible generated
 // passwords to users. It is set in page content, anchored at |anchor_rect|.
 // If the generated password is accepted by the user, the renderer associated
 // with |render_view_host| is informed of this password.
 class PasswordGenerationBubbleGtk {
  public:
   PasswordGenerationBubbleGtk(const gfx::Rect& anchor_rect,
                               GtkWidget* anchor_widget,
                               Profile* profile,
-                              content::RenderViewHost* render_view_host);
+                              content::RenderViewHost* render_view_host,
+                              autofill::PasswordGenerator* password_generator);
   virtual ~PasswordGenerationBubbleGtk();
 
  private:
   CHROMEGTK_CALLBACK_0(PasswordGenerationBubbleGtk, void, OnDestroy);
   CHROMEGTK_CALLBACK_0(PasswordGenerationBubbleGtk, void, OnAcceptClicked);
   CHROMEG_CALLBACK_0(
       PasswordGenerationBubbleGtk, void, OnLearnMoreLinkClicked, GtkButton*);
 
   BubbleGtk* bubble_;
   GtkWidget* text_field_;
   Profile* profile_;
 
   // RenderViewHost associated with the button that spawned this bubble.
   content::RenderViewHost* render_view_host_;
 
-  // Class that deals with generating passwords.
-  autofill::PasswordGenerator password_generator_;
+  // Object that deals with generating passwords.
+  scoped_ptr<autofill::PasswordGenerator> password_generator_;

[Ilya Sherman, 2012/06/04 22:49:15]

If the AutofillManager owns this object, this should be a weak reference rather
than a scoped_ptr.

[Garrett Casto, 2012/06/04 22:58:57]

Is a weak_ptr necessary, or does just a bare pointer suffice? I wouldn't think
that the TabContentsWrapper could disappear while input is being processed. The
overhead for the weak reference isn't that high, I'm just mostly curious.

[Ilya Sherman, 2012/06/04 23:08:22]

A bare pointer suffices.  I didn't actually mean to conjure up thoughts of
weak_ptr when I said "weak reference" -- a bare pointer is what I was thinking
of.

[zysxqn, 2012/06/04 23:17:19]

Done.

 
   DISALLOW_COPY_AND_ASSIGN(PasswordGenerationBubbleGtk);
 };
 
 #endif  // CHROME_BROWSER_UI_GTK_PASSWORD_GENERATION_BUBBLE_GTK_H_