This CL does the following: (1) Pass the max_length attribute to the password generator; (2) Update…

chrome/browser/autofill/autofill_manager.cc

Index: chrome/browser/autofill/autofill_manager.cc
diff --git a/chrome/browser/autofill/autofill_manager.cc b/chrome/browser/autofill/autofill_manager.cc
index 146c42923b90c724f4d569dc38f407cb45adf0ce..5b0ff270ba9e38e97b43fbd7ffcbda12d9161d93 100644
--- a/chrome/browser/autofill/autofill_manager.cc
+++ b/chrome/browser/autofill/autofill_manager.cc
@@ -28,6 +28,7 @@
 #include "chrome/browser/autofill/autofill_type.h"
 #include "chrome/browser/autofill/credit_card.h"
 #include "chrome/browser/autofill/form_structure.h"
+#include "chrome/browser/autofill/password_generator.h"
 #include "chrome/browser/autofill/personal_data_manager.h"
 #include "chrome/browser/autofill/personal_data_manager_factory.h"
 #include "chrome/browser/autofill/phone_number.h"
@@ -717,13 +718,16 @@ void AutofillManager::OnHideAutofillPopup() {
     external_delegate_->HideAutofillPopup();
 }
 
-void AutofillManager::OnShowPasswordGenerationPopup(const gfx::Rect& bounds) {
+void AutofillManager::OnShowPasswordGenerationPopup(const gfx::Rect& bounds,
+                                                    int max_length) {
 #if defined(OS_ANDROID)
   NOTIMPLEMENTED();
 #else
   Browser* browser = browser::FindLastActiveWithProfile(
       Profile::FromBrowserContext(web_contents()->GetBrowserContext()));
-  browser->window()->ShowPasswordGenerationBubble(bounds);
+  password_generator_.reset(new autofill::PasswordGenerator(max_length));
+  browser->window()->ShowPasswordGenerationBubble(
+      bounds, password_generator_.get());

[Ilya Sherman, 2012/06/04 22:52:32]

Is this bubble guaranteed to be hidden prior to the next call to
OnShowPasswordGenerationPopup()?  That is, is it actually safe for the
AutofillManager to free the old |password_generator_| as soon as a new bubble is
requested, or is it possible that an old bubble still needs the existing one?

[Garrett Casto, 2012/06/04 22:58:57]

At the moment the bubble is closed as soon as it loses focus, so this is safe.

 #endif  // #if defined(OS_ANDROID)
 }