chrome/browser/translate/translate_manager_browsertest.cc - Issue 10449094: Fix client-side phishing detection test flakiness and ChromeOS failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/translate/translate_manager_browsertest.cc

Issue 10449094: Fix client-side phishing detection test flakiness and ChromeOS failure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Generalize the fix and apply it to webrtc_audio_device_test Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sessions/tab_restore_service_browsertest.cc ('k') | chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc » ('j') | content/content_tests.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/translate/translate_manager_browsertest.cc

diff --git a/chrome/browser/translate/translate_manager_browsertest.cc b/chrome/browser/translate/translate_manager_browsertest.cc

index f85004f33ee29d137eef8f663d92503f60b92a16..6b0053cc6f36583a7c68b4d643f9efbf16e1b228 100644

--- a/chrome/browser/translate/translate_manager_browsertest.cc

+++ b/chrome/browser/translate/translate_manager_browsertest.cc

@@ -36,7 +36,7 @@

#include "content/public/browser/web_contents.h"

#include "content/test/mock_render_process_host.h"

#include "content/test/notification_observer_mock.h"

-#include "content/test/render_view_test.h"

+#include "content/test/render_test_utils.h"

#include "content/test/test_browser_thread.h"

#include "content/test/test_renderer_host.h"

@@ -255,8 +255,7 @@ class TranslateManagerTest : public TabContentsWrapperTestHarness,

content::NotificationRegistrar notification_registrar_;

TestURLFetcherFactory url_fetcher_factory_;

content::TestBrowserThread ui_thread_;

- content::RenderViewTest::RendererWebKitPlatformSupportImplNoSandbox

- webkit_platform_support_;

+ content::RendererWebKitPlatformSupportImplNoSandbox webkit_platform_support_;

// The infobars that have been removed.

// WARNING: the pointers point to deleted objects, use only for comparison.