chrome/browser/sessions/tab_restore_service_browsertest.cc - Issue 10449094: Fix client-side phishing detection test flakiness and ChromeOS failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/tab_restore_service_browsertest.cc

Issue 10449094: Fix client-side phishing detection test flakiness and ChromeOS failure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Generalize the fix and apply it to webrtc_audio_device_test Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sessions/tab_restore_service_browsertest.cc

diff --git a/chrome/browser/sessions/tab_restore_service_browsertest.cc b/chrome/browser/sessions/tab_restore_service_browsertest.cc

index 104e7eb65e83202543027c93fec3905255ad589c..c783c5f55fae6882d4d1cd4a46437e02d9cb7a4e 100644

--- a/chrome/browser/sessions/tab_restore_service_browsertest.cc

+++ b/chrome/browser/sessions/tab_restore_service_browsertest.cc

@@ -21,7 +21,7 @@

#include "content/public/browser/navigation_entry.h"

#include "content/public/browser/notification_service.h"

#include "content/public/browser/notification_types.h"

-#include "content/test/render_view_test.h"

+#include "content/test/render_test_utils.h"

#include "content/test/web_contents_tester.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "third_party/WebKit/Source/WebKit/chromium/public/WebKit.h"

@@ -138,8 +138,7 @@ class TabRestoreServiceTest : public ChromeRenderViewHostTestHarness {

GURL url3_;

scoped_ptr<TabRestoreService> service_;

TabRestoreTimeFactory* time_factory_;

- content::RenderViewTest::RendererWebKitPlatformSupportImplNoSandbox

- webkit_platform_support_;

+ content::RendererWebKitPlatformSupportImplNoSandbox webkit_platform_support_;

};

TEST_F(TabRestoreServiceTest, Basic) {

« no previous file with comments | « no previous file | chrome/browser/translate/translate_manager_browsertest.cc » ('j') | content/content_tests.gypi » ('J')