chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc - Issue 10449094: Fix client-side phishing detection test flakiness and ChromeOS failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc

Issue 10449094: Fix client-side phishing detection test flakiness and ChromeOS failure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Generalize the fix and apply it to webrtc_audio_device_test Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/translate/translate_manager_browsertest.cc ('k') | chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc » ('j') | content/content_tests.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc

diff --git a/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc b/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc

index 223333485684b35dfab8bc41c15a7e26f689bcad..27926dbc6b49bf426b9a74844e24016fb920df4c 100644

--- a/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc

+++ b/chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc

@@ -132,7 +132,7 @@ class PhishingClassifierTest : public RenderViewFakeResourcesTest {

ClientPhishingRequest verdict_;

};

-TEST_F(PhishingClassifierTest, DISABLED_TestClassification) {

+TEST_F(PhishingClassifierTest, TestClassification) {

// No scorer yet, so the classifier is not ready.

EXPECT_FALSE(classifier_->is_ready());