PPAPI/NaCl: Make a gyp flag for including the untrusted IPC proxy.

PPAPI/NaCl: Make a gyp flag for including the untrusted IPC proxy.

This way, those of us working on the proxy switch need only add:
{
  'variables': {
    'build_ppapi_ipc_proxy_untrusted': '1',
  },
}
to "~/.gyp/include.gypi"

...and we'll be able to build our untrusted targets without editing all.gyp. For anybody who doesn't set that flag, our ppapi_proxy_untrusted.gypi file will still be parsed, but it doesn't matter if the source files build (or even exist).

BUG=116317
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137751

[bbudge, 2012-05-17 18:16:35]

We've been needing this for a while. As we create untrusted builds for base,
ipc, etc., we should be able to use this flag.

LGTM

[commit-bot: I haz the power, 2012-05-17 18:27:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/10399068/1

[commit-bot: I haz the power, 2012-05-17 18:31:07]

Try job failure for 10399068-1 (retry) on mac_rel for step "update".
It's a second try, previously, step "update" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-05-17 19:31:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/10399068/6002

[dmichael (off chromium), 2012-05-17 19:41:41]

+brettw and mseaborn for FYI. I think this will make managing your local
branches and building the new proxy stuff easier. Planning to land soon (it's in
the CQ)

[Mark Seaborn, 2012-05-17 19:47:28]

http://codereview.chromium.org/10399068/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/10399068/diff/1/build/common.gypi#newcode277
build/common.gypi:277: # allows us to build this feature locally without it
affecting others
I still think we should build this by default on the bots to stop it
regressing...

http://codereview.chromium.org/10399068/diff/1/build/common.gypi#newcode279
build/common.gypi:279: 'build_untrusted_ipc_ppapi_proxy%': 0,
Isn't the convention that '_untrusted' is a suffix, to indicate that this is
just part of the ppapi proxy?  That would match the gyp file's name.

http://codereview.chromium.org/10399068/diff/1/ppapi/ppapi.gyp
File ppapi/ppapi.gyp (right):

http://codereview.chromium.org/10399068/diff/1/ppapi/ppapi.gyp#newcode11
ppapi/ppapi.gyp:11: ['disable_nacl==0 and build_untrusted_ipc_ppapi_proxy==1', {
The indentation is wrong here.  Subtract 2 spaces.

[dmichael (off chromium), 2012-05-17 20:21:33]

http://codereview.chromium.org/10399068/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/10399068/diff/1/build/common.gypi#newcode277
build/common.gypi:277: # allows us to build this feature locally without it
affecting others
On 2012/05/17 19:47:28, Mark Seaborn wrote:
> I still think we should build this by default on the bots to stop it
> regressing...
Yeah...  we definitely want to get there. I think the concern right now is that
we don't want developers working in base or ipc (for example) to have to worry
about our weird little file in ppapi.

When we have the gyp features we need, our build config will be in the
appropriate directory (e.g., we'll just exclude the right files from
base/base.gyp when in an untrusted build). I think that's when we'll get rid of
this flag.

http://codereview.chromium.org/10399068/diff/1/build/common.gypi#newcode279
build/common.gypi:279: 'build_untrusted_ipc_ppapi_proxy%': 0,
On 2012/05/17 19:47:28, Mark Seaborn wrote:
> Isn't the convention that '_untrusted' is a suffix, to indicate that this is
> just part of the ppapi proxy?  That would match the gyp file's name.
I didn't know we had a convention, but that works for me. Done.

http://codereview.chromium.org/10399068/diff/1/ppapi/ppapi.gyp
File ppapi/ppapi.gyp (right):

http://codereview.chromium.org/10399068/diff/1/ppapi/ppapi.gyp#newcode11
ppapi/ppapi.gyp:11: ['disable_nacl==0 and build_untrusted_ipc_ppapi_proxy==1', {
On 2012/05/17 19:47:28, Mark Seaborn wrote:
> The indentation is wrong here.  Subtract 2 spaces.

Done.

[dmichael (off chromium), 2012-05-17 20:23:01]

http://codereview.chromium.org/10399068/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/10399068/diff/1/build/common.gypi#newcode279
build/common.gypi:279: 'build_untrusted_ipc_ppapi_proxy%': 0,
On 2012/05/17 20:21:34, dmichael wrote:
> On 2012/05/17 19:47:28, Mark Seaborn wrote:
> > Isn't the convention that '_untrusted' is a suffix, to indicate that this is
> > just part of the ppapi proxy?  That would match the gyp file's name.
> I didn't know we had a convention, but that works for me. Done.
I should mention I swapped "ppapi" and "ipc" while I was at it... I think it's a
better name now, thanks.

[jochen (gone - plz use gerrit), 2012-05-18 21:15:32]

this breaks the WebKit build, as native_client/ is not part of our WebKit
checkout, and the untrusted gypi file depends on other gypi files in
native_client/

Can you please change this in such a way that that no additional gyp files are
parsed if the flag is not set?

[rniwa-cr, 2012-05-19 00:46:43]

This broke Chromium port in WebKit. I'm going to ask someone to (or I will)
revert the change if nobody can fix the problem in the next few hours.

[bbudge, 2012-05-19 00:52:56]

This should be fixed by:
http://codereview.chromium.org/10414010/

[rniwa-cr, 2012-05-19 01:13:33]

On 2012/05/19 00:52:56, bbudge1 wrote:
> This should be fixed by:
> http://codereview.chromium.org/10414010/

Thanks for the info!