Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Side by Side Diff: ppapi/ppapi.gyp

Issue 10399068: PPAPI/NaCl: Make a gyp flag for including the untrusted IPC proxy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: mseaborn's review comments. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « build/common.gypi ('k') | ppapi/ppapi_proxy_untrusted.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This is the "public" ppapi.gyp file, which must have dependencies on the 5 # This is the "public" ppapi.gyp file, which must have dependencies on the
6 # redistributable portions of PPAPI only. This prevents circular dependencies 6 # redistributable portions of PPAPI only. This prevents circular dependencies
7 # in the .gyp files (since ppapi_internal depends on parts of Chrome). 7 # in the .gyp files (since ppapi_internal depends on parts of Chrome).
8 8
9 { 9 {
10 'conditions': [
11 ['disable_nacl==0 and build_ppapi_ipc_proxy_untrusted==1', {
12 'includes': ['ppapi_proxy_untrusted.gypi'],
13 }],
14 ],
10 'variables': { 15 'variables': {
11 'chromium_code': 1, # Use higher warning level. 16 'chromium_code': 1, # Use higher warning level.
12 }, 17 },
13 'target_defaults': { 18 'target_defaults': {
14 'conditions': [ 19 'conditions': [
15 # Linux shared libraries should always be built -fPIC. 20 # Linux shared libraries should always be built -fPIC.
16 # 21 #
17 # TODO(ajwong): For internal pepper plugins, which are statically linked 22 # TODO(ajwong): For internal pepper plugins, which are statically linked
18 # into chrome, do we want to build w/o -fPIC? If so, how can we express 23 # into chrome, do we want to build w/o -fPIC? If so, how can we express
19 # that in the build system? 24 # that in the build system?
20 ['os_posix == 1 and OS != "mac"', { 25 ['os_posix == 1 and OS != "mac"', {
21 'cflags': ['-fPIC', '-fvisibility=hidden'], 26 'cflags': ['-fPIC', '-fvisibility=hidden'],
22 27
23 # This is needed to make the Linux shlib build happy. Without this, 28 # This is needed to make the Linux shlib build happy. Without this,
24 # -fvisibility=hidden gets stripped by the exclusion in common.gypi 29 # -fvisibility=hidden gets stripped by the exclusion in common.gypi
25 # that is triggered when a shared library build is specified. 30 # that is triggered when a shared library build is specified.
26 'cflags/': [['include', '^-fvisibility=hidden$']], 31 'cflags/': [['include', '^-fvisibility=hidden$']],
27 }], 32 }],
28 ], 33 ],
29 }, 34 },
30 'includes': [ 35 'includes': [
31 'ppapi_sources.gypi', 36 'ppapi_sources.gypi',
32 'ppapi_cpp.gypi', 37 'ppapi_cpp.gypi',
33 'ppapi_gl.gypi', 38 'ppapi_gl.gypi',
34 ], 39 ],
35 } 40 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | ppapi/ppapi_proxy_untrusted.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698