PPAPI/NaCl: Make a gyp flag for including the untrusted IPC proxy.

build/common.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 255 matching lines @@
       'enable_web_intents_tag%': 0,
 
       # Webrtc compilation is enabled by default. Set to 0 to disable.
       'enable_webrtc%': 1,
 
       # PPAPI by default does not support plugins making calls off the main
       # thread. Set to 1 to turn on experimental support for out-of-process
       # plugins to make call of the main thread.
       'enable_pepper_threading%': 0,
 
+      # Include the PPAPI IPC proxy for NaCl. This is a work-in-progress; this
+      # allows us to build this feature locally without it affecting others

[Mark Seaborn, 2012/05/17 19:47:28]

I still think we should build this by default on the bots to stop it
regressing...

[dmichael (off chromium), 2012/05/17 20:21:34]

Yeah...  we definitely want to get there. I think the concern right now is that
we don't want developers working in base or ipc (for example) to have to worry
about our weird little file in ppapi.

When we have the gyp features we need, our build config will be in the
appropriate directory (e.g., we'll just exclude the right files from
base/base.gyp when in an untrusted build). I think that's when we'll get rid of
this flag.

+      # working in affected subsystems like base and ipc.
+      'build_untrusted_ipc_ppapi_proxy%': 0,

[Mark Seaborn, 2012/05/17 19:47:28]

Isn't the convention that '_untrusted' is a suffix, to indicate that this is
just part of the ppapi proxy?  That would match the gyp file's name.

[dmichael (off chromium), 2012/05/17 20:21:34]

I didn't know we had a convention, but that works for me. Done.

[dmichael (off chromium), 2012/05/17 20:23:01]

I should mention I swapped "ppapi" and "ipc" while I was at it... I think it's a
better name now, thanks.

+
       # Enables use of the session service, which is enabled by default.
       # Support for disabling depends on the platform.
       'enable_session_service%': 1,
 
       # Enables theme support, which is enabled by default.  Support for
       # disabling depends on the platform.
       'enable_themes%': 1,
 
       # Enables support for background apps.
       'enable_background%': 1,
@@ skipping 230 matching lines @@
     'use_nss%': '<(use_nss)',
     'os_bsd%': '<(os_bsd)',
     'os_posix%': '<(os_posix)',
     'use_glib%': '<(use_glib)',
     'toolkit_uses_gtk%': '<(toolkit_uses_gtk)',
     'use_skia%': '<(use_skia)',
     'use_x11%': '<(use_x11)',
     'use_gnome_keyring%': '<(use_gnome_keyring)',
     'linux_fpic%': '<(linux_fpic)',
     'enable_pepper_threading%': '<(enable_pepper_threading)',
+    'build_untrusted_ipc_ppapi_proxy%': '<(build_untrusted_ipc_ppapi_proxy)',
     'chromeos%': '<(chromeos)',
     'use_virtual_keyboard%': '<(use_virtual_keyboard)',
     'enable_viewport%': '<(enable_viewport)',
     'enable_hidpi%': '<(enable_hidpi)',
     'enable_touch_ui%': '<(enable_touch_ui)',
     'enable_metro%': '<(enable_metro)',
     'use_xi2_mt%':'<(use_xi2_mt)',
     'file_manager_extension%': '<(file_manager_extension)',
     'webui_task_manager%': '<(webui_task_manager)',
     'inside_chromium_build%': '<(inside_chromium_build)',
@@ skipping 2558 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }