Chromium Code Reviews| Index: tools/test-runtime.dart |
| diff --git a/tools/test-runtime.dart b/tools/test-runtime.dart |
| index 498a787311b741948a85810de43a07c2a5a72826..64421f2bb3e0871832fac31fbd89736eeeb79d31 100755 |
| --- a/tools/test-runtime.dart |
| +++ b/tools/test-runtime.dart |
| @@ -53,14 +53,15 @@ main() { |
| // test.dart. However, don't do it if the silent progress indicator |
| // is used. This is only needed because of the junit tests. |
| if (progressIndicator != 'silent') { |
| - StringBuffer sb = new StringBuffer('Test configuration'); |
| - sb.add(configurations.length > 1 ? 's:' : ':'); |
| + List<String> output_words = configurations.length > 1 ? |
|
Bob Nystrom
2012/05/22 17:23:14
I would use "var" for these locals.
Bill Hesse
2012/05/23 08:49:20
Changed to List - it isn't much longer than var, a
|
| + ['Test configurations:'] : ['Test configuration:']; |
| for (Map conf in configurations) { |
| - sb.add(' ${conf["compiler"]}_${conf["runtime"]}_${conf["mode"]}_' + |
| - '${conf["arch"]}'); |
| - if (conf['checked']) sb.add('_checked'); |
| + List settings = |
| + ['compiler', 'runtime', 'mode', 'arch'].map((name) => conf[name]); |
| + if (conf['checked']) settings.add('checked'); |
| + output_words.add(Strings.join(settings, '_')); |
| } |
| - print(sb); |
| + print(Strings.join(output_words, ' ')); |
| } |
| var configurationIterator = configurations.iterator(); |