Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: tools/testing/dart/multitest.dart

Issue 10387232: Remove string concatenation with + from all Dart files in tools directory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/multitest.dart
diff --git a/tools/testing/dart/multitest.dart b/tools/testing/dart/multitest.dart
index 700287a6c0434d1c788fdacdf74031bff56678df..5170ac1f46a5fe553e78033548179ce4f1c67de5 100644
--- a/tools/testing/dart/multitest.dart
+++ b/tools/testing/dart/multitest.dart
@@ -91,13 +91,13 @@ void ExtractTestsFromMultitest(String filename,
if (annotation != null) {
testsAsLines.putIfAbsent(annotation.key,
() => new List<String>.from(testTemplate)).add(line);
- outcomes.putIfAbsent(annotation.key,
+ outcomes.putIfAbsent(annotation.key,
() => new Set<String>());
if (annotation.rest == 'continued') {
continue;
} else {
for (String nextOutcome in annotation.outcomesList) {
- outcomes[annotation.key].add(nextOutcome);
+ outcomes[annotation.key].add(nextOutcome);
if (!validMultitestOutcomes.contains(nextOutcome)) {
// TODO(zundel): fix long line
Expect.fail(
@@ -126,7 +126,7 @@ void ExtractTestsFromMultitest(String filename,
// Copy all the tests into the output map tests, as multiline strings.
for (String key in testsAsLines.getKeys()) {
tests[key] =
- Strings.join(testsAsLines[key], line_separator) + line_separator;
+ Strings.join(testsAsLines[key], line_separator).concat(line_separator);
}
}

Powered by Google App Engine
This is Rietveld 408576698