Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: tools/test.dart

Issue 10387232: Remove string concatenation with + from all Dart files in tools directory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/test.dart
diff --git a/tools/test.dart b/tools/test.dart
index d15e0d7eee808532382c9f607d55d789d33955db..da6566a0571c178edf8a04716530074f62ac47bc 100755
--- a/tools/test.dart
+++ b/tools/test.dart
@@ -83,14 +83,15 @@ main() {
// test.dart. However, don't do it if the silent progress indicator
// is used. This is only needed because of the junit tests.
if (progressIndicator != 'silent') {
- StringBuffer sb = new StringBuffer('Test configuration');
- sb.add(configurations.length > 1 ? 's:' : ':');
+ List<String> output_words = configurations.length > 1 ?
Bob Nystrom 2012/05/22 17:23:14 Ditto.
+ ['Test configurations:'] : ['Test configuration:'];
for (Map conf in configurations) {
- sb.add(' ${conf["compiler"]}_${conf["runtime"]}_${conf["mode"]}_' +
- '${conf["arch"]}');
- if (conf['checked']) sb.add('_checked');
+ List settings =
+ ['compiler', 'runtime', 'mode', 'arch'].map((name) => conf[name]);
+ if (conf['checked']) settings.add('checked');
+ output_words.add(Strings.join(settings, '_'));
}
- print(sb);
+ print(Strings.join(output_words, ' '));
}
var configurationIterator = configurations.iterator();

Powered by Google App Engine
This is Rietveld 408576698