Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Unified Diff: tools/ddbg.dart

Issue 10387232: Remove string concatenation with + from all Dart files in tools directory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/test.dart » ('j') | tools/test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/ddbg.dart
diff --git a/tools/ddbg.dart b/tools/ddbg.dart
index 4d7d6462964d8d6196ab19cffde637df5476e21e..f4f2b1cfd8be7626b7f7812fa4d0024af3fd6eb8 100644
--- a/tools/ddbg.dart
+++ b/tools/ddbg.dart
@@ -58,26 +58,26 @@ void processCommand(String cmdLine) {
if (args.length == 0) {
return;
}
- var cmd = args[0];
- if (cmd == "r") {
+ var command = args[0];
Bob Nystrom 2012/05/22 17:23:14 Nice change. :)
Bill Hesse 2012/05/23 08:49:20 Or I could have just removed the inner "var" decla
+ if (command == "r") {
var cmd = { "id": seqNum, "command": "resume" };
sendCmd(cmd).then((result) => handleGenericResponse(result));
- } else if (cmd == "s") {
+ } else if (command == "s") {
var cmd = { "id": seqNum, "command": "stepOver" };
sendCmd(cmd).then((result) => handleGenericResponse(result));
- } else if (cmd == "si") {
+ } else if (command == "si") {
var cmd = { "id": seqNum, "command": "stepInto" };
sendCmd(cmd).then((result) => handleGenericResponse(result));
- } else if (cmd == "so") {
+ } else if (command == "so") {
var cmd = { "id": seqNum, "command": "stepOut" };
sendCmd(cmd).then((result) => handleGenericResponse(result));
- } else if (cmd == "bt") {
+ } else if (command == "bt") {
var cmd = { "id": seqNum, "command": "getStackTrace" };
sendCmd(cmd).then((result) => handleStackTraceResponse(result));
- } else if (cmd == "ll") {
+ } else if (command == "ll") {
var cmd = { "id": seqNum, "command": "getLibraryURLs" };
sendCmd(cmd).then((result) => handleGetLibraryResponse(result));
- } else if (cmd == "sbp") {
+ } else if (command == "sbp") {
if (args.length < 3) {
return;
}
@@ -85,7 +85,7 @@ void processCommand(String cmdLine) {
"command": "setBreakpoint",
"params": { "url": args[1], "line": Math.parseInt(args[2]) }};
sendCmd(cmd).then((result) => handleSetBpResponse(result));
- } else if (cmd == "ls") {
+ } else if (command == "ls") {
if (args.length < 2) {
return;
}
@@ -93,12 +93,12 @@ void processCommand(String cmdLine) {
"command": "getScriptURLs",
"params": { "library": args[1] }};
sendCmd(cmd).then((result) => handleGetScriptsResponse(result));
- } else if (cmd == "q") {
+ } else if (command == "q") {
quitShell();
- } else if (cmd == "h") {
+ } else if (command == "h") {
printHelp();
} else {
- print("command '$cmd' not understood, try h for help");
+ print("command '$command' not understood, try h for help");
}
}
« no previous file with comments | « no previous file | tools/test.dart » ('j') | tools/test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698